Alex Clemmer created MESOS-5882:
-----------------------------------

             Summary: `os::cloexec` does not exist on Windows
                 Key: MESOS-5882
                 URL: https://issues.apache.org/jira/browse/MESOS-5882
             Project: Mesos
          Issue Type: Bug
          Components: stout
            Reporter: Alex Clemmer
            Assignee: Alex Clemmer


`os::cloexec` does not work on Windows. It will never work at the OS level. 
Because of this, there are likely many important and hard-to-detect bugs 
hanging around the agent.

This is extremely important to fix. Some possible solutions to investigate 
(some of which are _extremely_ risky):

* Abstract out file descriptors into a class, implement cloexec in that class 
on Windows (since we can't rely on the OS to do it).
* Refactor all the code that relies on `os::cloexec` to not rely on it.

Of the two, the first seems less risky in the short term, because the cloexec 
code only affects Windows. Depending on the semantics of the implementation of 
the `FileDescriptor` class, it is possible that this is riskier to Windows in 
the longer term, as the semantics of `cloexec` may have subtle difference 
between Linux and Windows.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to