[
https://issues.apache.org/jira/browse/MESOS-5797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422412#comment-15422412
]
Abhishek Dasgupta commented on MESOS-5797:
------------------------------------------
I am planning to start working on this.
So, just to confirm - should we change all raw pointers to shared_ptr for
Authorizers starting from "include/mesos/authorizer/authorizer.hpp" ?
IMO, it doesn't look good design if we just try to change Authorizer from raw
pointer to shared_ptr only in master, slave and files code because this would
require many back-and-forth conversions from shared_ptr to raw (or raw pointers
to shared_ptr).
> Use shared_ptr instead of raw pointer for mesos::Authorizer in slave and
> master initialization.
> -----------------------------------------------------------------------------------------------
>
> Key: MESOS-5797
> URL: https://issues.apache.org/jira/browse/MESOS-5797
> Project: Mesos
> Issue Type: Bug
> Components: general
> Reporter: Abhishek Dasgupta
> Assignee: Abhishek Dasgupta
>
> Like in slave.hpp, to initialize Slave instance, we are using "const
> Option<Authorizer*>& authorizer" raw pointer. Instead of a raw pointer, we
> may use shared_ptr here as this pointer might be shared among other objects
> also to support authorization in those.
> Similarly, it can be done for master initialization also.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
