[
https://issues.apache.org/jira/browse/MESOS-6074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450211#comment-15450211
]
Yan Xu commented on MESOS-6074:
-------------------------------
{noformat:title=}
commit 1364aa5617743f052f25b278d9ba931b9bb806da
Author: Jiang Yan Xu <[email protected]>
Date: Tue Aug 30 09:35:06 2016 -0700
Added 'HierarchicalAllocatorTest.ResourceMetricsUninitialized' test.
To test the fix (https://reviews.apache.org/r/51529/) for a
CHECK failure in HierarchicalAllocatorProcess due to uninitialized
sorter pointers.
Review: https://reviews.apache.org/r/51528
commit f4e9631ca6c35625a9bea3b298ba5f9d30478d33
Author: Jiang Yan Xu <[email protected]>
Date: Tue Aug 23 22:41:16 2016 -0700
Initialize sorter pointers in HierarchicalAllocatorProcess constructor.
Otherwise the sorter pointers can be uninitialized if the metrics
endpoint is polled before the master is initialized.
Review: https://reviews.apache.org/r/51529
{noformat}
> Master check failure if the metrics endpoint is polled soon after it starts
> ---------------------------------------------------------------------------
>
> Key: MESOS-6074
> URL: https://issues.apache.org/jira/browse/MESOS-6074
> Project: Mesos
> Issue Type: Bug
> Components: master
> Affects Versions: 1.0.0
> Reporter: Yan Xu
> Assignee: Yan Xu
> Priority: Critical
> Fix For: 1.1.0, 1.0.2
>
>
> We observed the following check failure
> {noformat:title=}
> F0822 22:27:10.364923 10489 owned.hpp:110] Check failed: 'get()' Must be non
> NULL
> {noformat}
> called from
> {{mesos::internal::master::allocator::internal::HierarchicalAllocatorProcess::_resources_total}}
>
> The code:
> {code}
> double HierarchicalAllocatorProcess::_resources_total(
> const string& resource)
> {
> Option<Value::Scalar> total =
> roleSorter->totalScalarQuantities()
> .get<Value::Scalar>(resource);
> return total.isSome() ? total->value() : 0;
> }
> {code}
> See
> [github|https://github.com/apache/mesos/blob/dcc8bd7d2a942889fe473c21ab64e863d0e6a13f/src/master/allocator/mesos/hierarchical.cpp#L1804]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
