[ 
https://issues.apache.org/jira/browse/MESOS-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15458865#comment-15458865
 ] 

Michael Park commented on MESOS-4907:
-------------------------------------

{noformat}
commit 66921a427edb018fc4b2d0a54eaf32c30272a164
Author: Benjamin Bannier <[email protected]>
Date:   Fri Sep 2 17:42:22 2016 +0200

    Fixed remaining quoting issues.

    `CONFIGURE_FLAGS` might be multiple arguments so a passed string
    should always be exploded when used. Conversely, `SRCDIR` can only be
    used as a single argument; we do know that it does not contain spaces,
    but should quote it nevertheless for consistency.

    Review: https://reviews.apache.org/r/51603/
{noformat}

> ClangTidy Integration
> ---------------------
>
>                 Key: MESOS-4907
>                 URL: https://issues.apache.org/jira/browse/MESOS-4907
>             Project: Mesos
>          Issue Type: Epic
>          Components: technical debt
>            Reporter: Michael Park
>              Labels: gsoc, gsoc2016, mentor, mesosphere
>
> While {{cpplint}} has been a useful tool as a C++ linter for quite some time,
> It carries limitations since it does its best without actually parsing C++.
> [ClangTidy|http://clang.llvm.org/extra/clang-tidy/] is a clang tool that is 
> based
> off of Clang, and has the advantage that it has access to a full AST.
> There are many checks that come built-in with {{clang-tidy}} which are very 
> useful,
> but we can extend it to fit Mesos coding style and patterns as well.
> The initial phase of the project will be to create a basis with which to 
> leverage
> the existing checks as applicable to Mesos, then to create a scaffolding to 
> add
> custom checks, and ways to integrate the custom checks to infrastructure such
> as Mesos ReviewBot, or Apache CI.
> I've done some preliminary, experimental work for this for a Hackathon project
> and have given a 
> [presentation|https://docs.google.com/presentation/d/1z_qGzpY7Mt46TXxuLRW6M5HcCWBLRz6UJfd4bPknYeg/edit?usp=sharing]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to