[ 
https://issues.apache.org/jira/browse/MESOS-6122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15467768#comment-15467768
 ] 

Joris Van Remoortere commented on MESOS-6122:
---------------------------------------------

[~jieyu] This change looks ok.
[~gena01] Can you please provide logs for the errors you ran into? I don't 
understand how the logical order evaluation here is a {{bug}} unless you are 
running into an error during the {{exists}} check. If so can you please augment 
this ticket with that information? At this point all we are doing is masking 
that problem.
Otherwise this is purely an optimization.

> Mesos slave throws systemd errors even when passed a flag to disable systemd
> ----------------------------------------------------------------------------
>
>                 Key: MESOS-6122
>                 URL: https://issues.apache.org/jira/browse/MESOS-6122
>             Project: Mesos
>          Issue Type: Bug
>          Components: slave
>    Affects Versions: 1.0.1
>            Reporter: Gennady Feldman
>            Assignee: Jie Yu
>             Fix For: 1.1.0, 1.0.2
>
>
> Seems like the code in slave/main.cpp is logically in the wrong order:
> #ifdef __linux__
>   // Initialize systemd if it exists.
> if (systemd::exists() && flags.systemd_enable_support) {
> Lines 339-341: 
> https://github.com/apache/mesos/blob/master/src/slave/main.cpp#L341
> The flags should come first before the systemd::exists() check runs.Currently 
> the systemd.exists() always runs and there's no way to disable that check 
> from running in mesos-slave.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to