[ 
https://issues.apache.org/jira/browse/MESOS-6216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Bannier updated MESOS-6216:
------------------------------------
    Description: 
{{LibeventSSLSocketImpl::create}} is called whenever a potentially ssl-enabled 
socket is created. It in turn calls {{openssl::initialize}} which calls a 
function {{reinitialize}} using {{os::setenv}}. Here {{os::setenv}} is used to 
set up SSL-related libprocess environment variables {{LIBPROCESS_SSL_*}}.

Since {{os::setenv}} is not thread-safe just like the {{::setenv}} it wraps, 
any calling of functions like {{os::getenv}} (or via {{os::environment}}) 
concurrently with the first invocation of {{LibeventSSLSocketImpl::create}} 
performs unsynchronized r/w access to the same data structure in the runtime.

We usually perform most setup of the environment before we start the libprocess 
runtime with {{process::initialize}} from a {{main}} function, see e.g., 
{{src/slave/main.cpp}} or {{src/master/main.cpp}} and others. It appears that 
we should move the setup of libprocess' SSL environment variables to a similar 
spot.

  was:
{{LibeventSSLSocketImpl::create}} is called whenever a potentially ssl-enabled 
socket is created. It in turn calls {{openssl::initialize}} which calls a 
function {{reinitialize}} using {{os::setenv}}. Here {{os::setenv}} is used to 
set up SSL-related libprocess environment variables {{LIBPROCESS_SSL_*}}.

Since {{os::setenv}} is not thread-safe just like the {{::setenv}} it wraps, 
any code calling functions like {{os::getenv}} (via or {{os::environment}}) 
concurrently with the first invocation of {{LibeventSSLSocketImpl::create}} 
perform unsynchronized r/w access to the same data structure in the runtime.

We usually perform most setup of the environment before we start the libprocess 
runtime with {{process::initialize}} from a {{main}} function, see e.g., 
{{src/slave/main.cpp}} or {{src/master/main.cpp}} and others. It appears that 
we should move the setup of libprocess' SSL environment variables to a similar 
spot.


> LibeventSSLSocketImpl::create is not safe to call concurrently with os::getenv
> ------------------------------------------------------------------------------
>
>                 Key: MESOS-6216
>                 URL: https://issues.apache.org/jira/browse/MESOS-6216
>             Project: Mesos
>          Issue Type: Bug
>          Components: security
>            Reporter: Benjamin Bannier
>         Attachments: build.log
>
>
> {{LibeventSSLSocketImpl::create}} is called whenever a potentially 
> ssl-enabled socket is created. It in turn calls {{openssl::initialize}} which 
> calls a function {{reinitialize}} using {{os::setenv}}. Here {{os::setenv}} 
> is used to set up SSL-related libprocess environment variables 
> {{LIBPROCESS_SSL_*}}.
> Since {{os::setenv}} is not thread-safe just like the {{::setenv}} it wraps, 
> any calling of functions like {{os::getenv}} (or via {{os::environment}}) 
> concurrently with the first invocation of {{LibeventSSLSocketImpl::create}} 
> performs unsynchronized r/w access to the same data structure in the runtime.
> We usually perform most setup of the environment before we start the 
> libprocess runtime with {{process::initialize}} from a {{main}} function, see 
> e.g., {{src/slave/main.cpp}} or {{src/master/main.cpp}} and others. It 
> appears that we should move the setup of libprocess' SSL environment 
> variables to a similar spot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to