[ https://issues.apache.org/jira/browse/MESOS-5070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510527#comment-15510527 ]
Jie Yu commented on MESOS-5070: ------------------------------- commit 3c730dc42e35d13dbeaf69ce391766d4ba7ba962 Author: Joerg Schad <jo...@mesosphere.io> Date: Wed Sep 21 09:50:43 2016 -0700 Converted watchdog option into childhook in Mesos [2/2]. Review: https://reviews.apache.org/r/52121/ commit 6d58c241716244d29a932440eabed31dccb639cf Author: Joerg Schad <jo...@mesosphere.io> Date: Wed Sep 21 09:50:39 2016 -0700 Converted watchdog option into a childhook in libprocess [1/2]. Review: https://reviews.apache.org/r/52120/ commit f4be028f5eb8c04a2c13a58863896ad4f571d541 Author: Joerg Schad <jo...@mesosphere.io> Date: Wed Sep 21 09:50:36 2016 -0700 Renamed Hook to ParentHook in Mesos [2/2]. Review: https://reviews.apache.org/r/52018/ commit 6a4a4f1a29301c1bac74042138f6bb3428adc9f3 Author: Joerg Schad <jo...@mesosphere.io> Date: Wed Sep 21 09:50:33 2016 -0700 Renamed Hook to parent Hook in libprocess [1/2]. Review: https://reviews.apache.org/r/52017/ commit 1db3bbb1692406f6395a21624d2041f220eca744 Author: Joerg Schad <jo...@mesosphere.io> Date: Wed Sep 21 09:50:30 2016 -0700 Replaces Hook::None() by {} in Mesos [2/2]. Review: https://reviews.apache.org/r/52016/ commit 2af7e5ebae976735d263f45e540c886111d27982 Author: Joerg Schad <jo...@mesosphere.io> Date: Wed Sep 21 09:50:26 2016 -0700 Used {} instead of Hook::None() in libprocess [1/2]. Review: https://reviews.apache.org/r/52015/ commit 059f47bfe82c2c589cefbf0bcab131697cb0d9f9 Author: Joerg Schad <jo...@mesosphere.io> Date: Wed Sep 21 09:50:19 2016 -0700 Used ChildHooks in Mesos [2/2]. We now use the new ChildHooks instead of explicit options such as setsid. Review: https://reviews.apache.org/r/45492/ commit 5ce0e46aeb083de1af09d53364ac7260441e9e94 Author: Joerg Schad <jo...@mesosphere.io> Date: Wed Sep 21 09:50:15 2016 -0700 Refactored subprocess options [1/2]. Previously the subprocess interface supported a several options for the child process such as setsid. In order to make the interface more flexible we refactored such options into a vector of ChildHooks. In order not to allow arbitrary code inside a ChildHook it has to be constructed via pre-defined factory methods. Review: https://reviews.apache.org/r/45491/ > Introduce more flexible subprocess interface for child options. > --------------------------------------------------------------- > > Key: MESOS-5070 > URL: https://issues.apache.org/jira/browse/MESOS-5070 > Project: Mesos > Issue Type: Improvement > Reporter: Joerg Schad > Assignee: Joerg Schad > Labels: tech-debt > > We introduced a number of parameters to the subprocess interface with > MESOS-5049. > Adding all options explicitly to the subprocess interface makes it > inflexible. > We should investigate a flexible options, which still prevents arbitrary code > to be executed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)