[ 
https://issues.apache.org/jira/browse/MESOS-3454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514297#comment-15514297
 ] 

Greg Mann commented on MESOS-3454:
----------------------------------

[~mcypark] I think you and I have looked at this code before and discussed the 
possibility of refactoring; any interest/time to shepherd?

> Remove duplicated logic in Flags::load
> --------------------------------------
>
>                 Key: MESOS-3454
>                 URL: https://issues.apache.org/jira/browse/MESOS-3454
>             Project: Mesos
>          Issue Type: Bug
>          Components: stout
>            Reporter: Klaus Ma
>            Priority: Minor
>
> In {{flags.hpp}}, there are two functions with almost the same logic; this 
> ticket is used to merge the duplicated part.
> {code}
> inline Try<Nothing> FlagsBase::load(
>     const Option<std::string>& prefix,
>     int* argc,
>     char*** argv,
>     bool unknowns,
>     bool duplicates)
> ...
> inline Try<Nothing> FlagsBase::load(
>     const Option<std::string>& prefix,
>     int argc,
>     const char* const *argv,
>     bool unknowns,
>     bool duplicates)
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to