[
https://issues.apache.org/jira/browse/MESOS-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Schlicht updated MESOS-6253:
--------------------------------
Description:
A {{Result}} behaves like a {{Try<Option>}}, which means it can be {{Some}},
{{None}} or an error. Only in case of an error can {{Result::error}} get
called, otherwise an assertion will fail, see e.g. MESOS-6226. We need to make
sure that this is followed throughout the code. There are occurrences like
{noformat}
if (!realpath.isSome()) {
return Error(realpath.error());
}
{noformat}
and probably others that are wrong. These need to be fixed.
was:
A {{Result}} behaves like a {{Try<Option>}}, which means it can be {{Some}},
{{None}} or an error. Only in case of an error can {{Result::error}} get
called, otherwise an assertion will fail, see e.g. MESOS-6226. We need to make
sure that this is followed throughout the code. There are occurrences like
{{noformat}}
if (!realpath.isSome()) {
return Error(realpath.error());
}
{{noformat}}
and probably others that are wrong. These need to be fixed.
> Make sure the 'Result' errors are checked correctly.
> ----------------------------------------------------
>
> Key: MESOS-6253
> URL: https://issues.apache.org/jira/browse/MESOS-6253
> Project: Mesos
> Issue Type: Bug
> Reporter: Jan Schlicht
> Labels: newbie, tech-debt
>
> A {{Result}} behaves like a {{Try<Option>}}, which means it can be {{Some}},
> {{None}} or an error. Only in case of an error can {{Result::error}} get
> called, otherwise an assertion will fail, see e.g. MESOS-6226. We need to
> make sure that this is followed throughout the code. There are occurrences
> like
> {noformat}
> if (!realpath.isSome()) {
> return Error(realpath.error());
> }
> {noformat}
> and probably others that are wrong. These need to be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
