[
https://issues.apache.org/jira/browse/MESOS-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Bannier updated MESOS-6604:
------------------------------------
Description:
In {{include/mesos/authorizer/authorizer.hpp}} the member
{{ObjectApprover::weight_info}} is a raw ptr which is not initialized (with
{{nullptr}}) in the ctr.
While the member is {{public}}, requiring users to set up the {{class}} is
error-prone; it is also contrary to what is done for other members.
Instead this member should be initialized to {{nullptr}}. As a more long-term
solution we should consider introducing some non-owning wrapper for raw ptrs to
stout which on construction initializes the raw ptr, see MESOS-6603.
This was detected by coverity as CID 1394390.
was:
In {{include/mesos/authorizer/authorizer.hpp}} the member
{{ObjectApprover::weight_info}} is a raw ptr which is not initialized (with
{{nullptr}}) in the ctr.
While the member is {{public}}, requiring users to set up the {{class}} is
error-prone; it is also contrary to what is done for other members.
Instead this member should be initialized to {{nullptr}}. As a more long-term
solution we should consider introducing some non-owning wrapper for raw ptrs to
stout which on construction initializes the raw ptr, see MESOS-6603.
> Uninitialized member ObjectApprover::weight_info
> ------------------------------------------------
>
> Key: MESOS-6604
> URL: https://issues.apache.org/jira/browse/MESOS-6604
> Project: Mesos
> Issue Type: Bug
> Reporter: Benjamin Bannier
> Labels: coverity, tech-debt
>
> In {{include/mesos/authorizer/authorizer.hpp}} the member
> {{ObjectApprover::weight_info}} is a raw ptr which is not initialized (with
> {{nullptr}}) in the ctr.
> While the member is {{public}}, requiring users to set up the {{class}} is
> error-prone; it is also contrary to what is done for other members.
> Instead this member should be initialized to {{nullptr}}. As a more long-term
> solution we should consider introducing some non-owning wrapper for raw ptrs
> to stout which on construction initializes the raw ptr, see MESOS-6603.
> This was detected by coverity as CID 1394390.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
