[
https://issues.apache.org/jira/browse/MESOS-5662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anand Mazumdar updated MESOS-5662:
----------------------------------
Description:
There are some occurrences in our code where we don't invoke the parent's
{{SetUpTestCase}} method from a child test fixture. This can be a bit
problematic if the parent class has its own custom {{SetUpTestCase}} logic or
someone adds one in the future. It would be good to do a sweep across the code
and explicitly invoke the parent class's method.
Some examples (there are more):
https://github.com/apache/mesos/blob/master/src/tests/mesos.cpp#L80
https://github.com/apache/mesos/blob/master/src/tests/module_tests.cpp#L59
was:
There are some occurrences in our code where we don't invoke the parent's
{{SetUpTestCase}} method from a child test fixture. This can be a bit
problematic if someone adds the method in the parent class sometime in the
future. It would be good to do a sweep across the code and explicitly invoke
the parent class's method.
Some examples (there are more):
https://github.com/apache/mesos/blob/master/src/tests/mesos.cpp#L80
https://github.com/apache/mesos/blob/master/src/tests/module_tests.cpp#L59
> Call parent class `SetUpTestCase` function in our test fixtures.
> ----------------------------------------------------------------
>
> Key: MESOS-5662
> URL: https://issues.apache.org/jira/browse/MESOS-5662
> Project: Mesos
> Issue Type: Bug
> Components: test
> Reporter: Anand Mazumdar
> Assignee: Manuwela Kanade
> Labels: mesosphere, newbie
>
> There are some occurrences in our code where we don't invoke the parent's
> {{SetUpTestCase}} method from a child test fixture. This can be a bit
> problematic if the parent class has its own custom {{SetUpTestCase}} logic or
> someone adds one in the future. It would be good to do a sweep across the
> code and explicitly invoke the parent class's method.
> Some examples (there are more):
> https://github.com/apache/mesos/blob/master/src/tests/mesos.cpp#L80
> https://github.com/apache/mesos/blob/master/src/tests/module_tests.cpp#L59
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
