[
https://issues.apache.org/jira/browse/MESOS-6648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15706325#comment-15706325
]
Jie Yu commented on MESOS-6648:
-------------------------------
commit 8d27b8cbfcd00e84061a9a26a3e50116c34f04db
Author: Jie Yu <[email protected]>
Date: Sat Nov 26 23:32:26 2016 -0800
Made MesosContainerizer launch helper to take ContainerLaunchInfo.
Prior to this patch, the launch helper takes various flags from
MesosContainerizer to launch the container. This makes it very hard to
add more parameters to the launch helper. This patch simplifies this
by passing 'ContainerLaunchInfo' instead. 'ContainerLaunchInfo' is
also the protobuf message returned by isolators during 'prepare()'.
This makes it very easy to merge them and send it to the launch
helper. More importantly, this makes it very easy to add more
parameters to the launch helper in the future.
Review: https://reviews.apache.org/r/54103
commit 93eacdb16d2622f862522e51a60ab1b91d1d66da
Author: Jie Yu <[email protected]>
Date: Sat Nov 26 22:44:49 2016 -0800
Moved the default PATH setting to containerizer.
Currently, it is set as part of the executor environment. This is not
ideal because isolators might choose to set environment variables for
the contianer. We should set the default PATH in the last step (right
before launch) if it does not exist.
Mesos containerizer launch helper already does default PATH setting
right before launching the container. This patch did the same in
Docker containerizer, and remove the default PATH setting when
generating the executor environment.
Review: https://reviews.apache.org/r/54102
commit 418433ddc1effd0d8f75d9fc426c8a4cb6c70f96
Author: Jie Yu <[email protected]>
Date: Sat Nov 26 21:02:32 2016 -0800
Removed MesosContainerizerLaunchTest.
This test is not necessary as we already test that in linux filesystem
isolator tests. This patch removes it.
Review: https://reviews.apache.org/r/54101
commit fbbe2a111b895e53970867c175290d3ef72223fd
Author: Jie Yu <[email protected]>
Date: Sat Nov 26 20:46:20 2016 -0800
Removed two disabled shared filesystem isolator tests.
Shared filesystem isolator has been deprecated for a while, and those
two tests are disabled all the time. This patch removes them.
Review: https://reviews.apache.org/r/54100
commit 9d6cbf0b32f1760a07fff0c4409fa815ba5d9634
Author: Jie Yu <[email protected]>
Date: Thu Nov 24 23:53:45 2016 -0800
Used environment to pass flags to launch helper.
Instead of doing that just for command environment variables, this
patch does it consistently by using environment variables to pass
launch helper flags. This will be more secure.
Review: https://reviews.apache.org/r/54099
commit 08ff8763e5e43761e08b1297b16eed6fef4a4fc7
Author: Jie Yu <[email protected]>
Date: Thu Nov 24 22:41:03 2016 -0800
Moved a VLOG to a proper place in MesosContainerizer.
We should print the VLOG after we calculate the launch flags.
Review: https://reviews.apache.org/r/54098
commit c06c697693a5bc78fd210a10b0df1b2ab2780a18
Author: Jie Yu <[email protected]>
Date: Thu Nov 24 00:11:02 2016 -0800
Added support for building environment variables from flags.
This patch added a method to FlagsBase to build a map of environment
variables from the flags. This simplifies the logic when the caller
wants to pass flags as environment variables to the subprocess.
Review: https://reviews.apache.org/r/54097
commit afab55a3579aa04ad81db00c52389255ae27fb48
Author: Jie Yu <[email protected]>
Date: Thu Nov 24 00:08:51 2016 -0800
Fixed an indentation problem in Subcommand.
Review: https://reviews.apache.org/r/54096
commit 0b6ac2f34dec26e80edc2c5590dd33d565b97d8f
Author: Jie Yu <[email protected]>
Date: Wed Nov 23 17:19:21 2016 -0800
Removed an unused function in launch helper.
Review: https://reviews.apache.org/r/54095
> MesosContainerizer launch helper should take ContainerLaunchInfo.
> -----------------------------------------------------------------
>
> Key: MESOS-6648
> URL: https://issues.apache.org/jira/browse/MESOS-6648
> Project: Mesos
> Issue Type: Improvement
> Reporter: Jie Yu
> Assignee: Jie Yu
> Labels: mesosphere
> Fix For: 1.2.0
>
>
> Currently, the launch helper takes various flags from MesosContainerizer to
> launch the container. This makes it very hard to add more parameters to the
> launch helper. To simplify that, MesosContainerizer can pass
> 'ContainerLaunchInfo' to the launch helper instead. 'ContainerLaunchInfo' is
> also the protobuf message returned by isolators during 'prepare()'. This
> makes it very easy to merge them and send it to the launch helper. More
> importantly, this makes it very easy to add more parameters to the launch
> helper in the future.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
