[
https://issues.apache.org/jira/browse/MESOS-6753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neil Conway updated MESOS-6753:
-------------------------------
Description:
It would be nice to refactor the code and eliminate some/all of these
redundancies:
* {{Master::activateRecoveredFramework}} and {{Master::\_failoverFramework}}
duplicate some code.
* {{Master::\_subscribe}} for PID-based schedulers has a code path that
contains code that is _very_ similar to the {{Master::failoverFramework}}
logic, but is not identical.
* The logic around {{updateConnection}} could stand to be cleaned up. e.g., it
seems like {{updateConnection}} could/should be responsible for linking to the
target PID and/or setting up the {{closed}} callback (for PID or HTTP
schedulers, respectively).
was:
It would be nice to refactor the code and eliminate some/all of these
redundancies:
* {{Master::activateRecoveredFramework}} and {{Master::_failoverFramework}}
duplicate some code.
* {{Master::_subscribe}} for PID-based schedulers has a code path that contains
code that is _very_ similar to the {{Master::failoverFramework}} logic, but is
not identical.
* The logic around {{updateConnection}} could stand to be cleaned up. e.g., it
seems like {{updateConnection}} could/should be responsible for linking to the
target PID and/or setting up the {{closed}} callback (for PID or HTTP
schedulers, respectively).
> Refactor duplicated code for framework registration in master
> -------------------------------------------------------------
>
> Key: MESOS-6753
> URL: https://issues.apache.org/jira/browse/MESOS-6753
> Project: Mesos
> Issue Type: Bug
> Components: master
> Reporter: Neil Conway
> Labels: mesosphere
>
> It would be nice to refactor the code and eliminate some/all of these
> redundancies:
> * {{Master::activateRecoveredFramework}} and {{Master::\_failoverFramework}}
> duplicate some code.
> * {{Master::\_subscribe}} for PID-based schedulers has a code path that
> contains code that is _very_ similar to the {{Master::failoverFramework}}
> logic, but is not identical.
> * The logic around {{updateConnection}} could stand to be cleaned up. e.g.,
> it seems like {{updateConnection}} could/should be responsible for linking to
> the target PID and/or setting up the {{closed}} callback (for PID or HTTP
> schedulers, respectively).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
