[
https://issues.apache.org/jira/browse/MESOS-4871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15824372#comment-15824372
]
Benjamin Bannier commented on MESOS-4871:
-----------------------------------------
This cleanup can be performed automatically with clang-tidy's
{{modernize-use-override}} check. Once we implement a fix here we should make
sure to add {{modernize-use-override}} to [our clang-tidy
setup|https://github.com/apache/mesos/blob/e49a343e551fb9f332760ba2240f2805de35c1b8/support/mesos-tidy.sh#L29]
and potentially also update the style guide to avoid confusion.
> Make use of C++11 `override` keyword
> ------------------------------------
>
> Key: MESOS-4871
> URL: https://issues.apache.org/jira/browse/MESOS-4871
> Project: Mesos
> Issue Type: Improvement
> Components: general
> Reporter: Neil Conway
> Labels: mesosphere, tech-debt
>
> Per Google C++ style guide (as well as general common sense), we should
> probably be using the {{override}} keyword to explicitly denote situations
> where we expect a virtual member function declaration to override a virtual
> function declared in a parent class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
