[ 
https://issues.apache.org/jira/browse/MESOS-6606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828284#comment-15828284
 ] 

Benjamin Bannier commented on MESOS-6606:
-----------------------------------------

[~tillt] mentioned another possible way to detect if the used libcxx version 
has a fixed,
{code}
+#define _LIBCPP_ABI_TREE_REMOVE_NODE_POINTER_UB
{code}
That might make it possible to implement an even lighter fix in the autoconf 
setup.

> Reject optimized builds with libcxx before 3.9
> ----------------------------------------------
>
>                 Key: MESOS-6606
>                 URL: https://issues.apache.org/jira/browse/MESOS-6606
>             Project: Mesos
>          Issue Type: Bug
>          Components: libprocess, stout
>            Reporter: Benjamin Bannier
>
> Recent clang versions optimize more aggressively which leads to runtime 
> errors using valid code, see e.g., MESOS-5745, due to code exposing undefined 
> behavior in libcxx-3.8 and earlier. This was fixed with upstream libcxx-3.9. 
> See https://reviews.llvm.org/D20786 for the patch and 
> https://llvm.org/bugs/show_bug.cgi?id=28469 for the code example extracted 
> from our code base.
> We should consider rejecting builds if libcxx-3.8 or older is detected since 
> not all users compiling Mesos might run the test suite. In our decision to 
> reject we could possibly also take the used clang versions into account 
> (which would just ensure we don't run into the known problems from the UB in 
> libcxx).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to