Benjamin Bannier created MESOS-7072:
---------------------------------------
Summary: Master's internal validation routines use incorrect
argument type to pass parameters
Key: MESOS-7072
URL: https://issues.apache.org/jira/browse/MESOS-7072
Project: Mesos
Issue Type: Bug
Components: master
Reporter: Benjamin Bannier
A number of functions in the {{master::validation}} namespace take arguments as
non-{{const}} {{T*}} with no intention to modify them. To combat possible
{{nullptr}} values most of these functions guard the argument with
{{CHECK_NOTNULL}}.
We should audit these functions and make sure to pass these parameters by
{{const T&}} where possible instead. This might require explicitly declaring a
number of used and already semantically const functions as {{const}} (e.g.,
{{Master::getOffer}} and others).
Note: The style guide suggests using {{const T&}} for "in parameters", and
{{T*}} for "out parameters".
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
