[
https://issues.apache.org/jira/browse/MESOS-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866684#comment-15866684
]
James Peach edited comment on MESOS-7115 at 2/14/17 9:08 PM:
-------------------------------------------------------------
|Apply glog to agent exit messages. | https://reviews.apache.org/r/56680/ |
|Use glog to log EXIT() messages. | https://reviews.apache.org/r/56681/ |
The first review explicitly updates all the uses of {{EXIT()}} in
{{src/slave/slave.cpp}} in a way that made sense to me. The second review
changes {{EXIT()}} to use {{glog}} internally.
We could apply both, either or none of these patches :)
was (Author: jamespeach):
|Apply glog to agent exit messages. | https://reviews.apache.org/r/56680/ |
|Use glog to log EXIT() messages. | https://reviews.apache.org/r/56681/ |
The first review explicitly updates all the uses of {{EXIT()}} in
{{src/slave/slave.cpp}} in a way that made sense to me.
The second review changes {{EXIT()}} to use {{glog}} internally.
We could apply both, either or none of these patches :)
> Agent should prefer LOG(FATAL) over EXIT().
> -------------------------------------------
>
> Key: MESOS-7115
> URL: https://issues.apache.org/jira/browse/MESOS-7115
> Project: Mesos
> Issue Type: Bug
> Components: agent
> Reporter: James Peach
> Assignee: James Peach
> Priority: Minor
>
> I saw the agent exit with an auth failure:
> {noformat}
> I0210 14:16:49.731459 9503 authenticatee.cpp:259] Received SASL
> authentication step
> Master [email protected]:5050 refused authentication
> {noformat}
> Note the lack of log metadata on the exit message. This message (from
> {{slave.cpp}} and a number of others in the same file should all use
> {{LOG(FATAL)}} so that log aggregation can pick up the timestamp, error
> severity, etc.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
