Jie Yu created MESOS-7304:
-----------------------------

             Summary: Fetcher should not depends on SlaveID.
                 Key: MESOS-7304
                 URL: https://issues.apache.org/jira/browse/MESOS-7304
             Project: Mesos
          Issue Type: Task
          Components: containerization, fetcher
            Reporter: Jie Yu


Currently, various Fetcher interfaces depends on SlaveID, which is an 
unnecessary coupling. For instance:
{code}
Try<Nothing> Fetcher::recover(const SlaveID& slaveId, const Flags& flags);

Future<Nothing> Fetcher::fetch(
    const ContainerID& containerId,
    const CommandInfo& commandInfo,
    const string& sandboxDirectory,
    const Option<string>& user,
    const SlaveID& slaveId,
    const Flags& flags);
{code}

Looks like the only reason we need a SlaveID is because we need to calculate 
the fetcher cache directory based on that. We should calculate the fetcher 
cache directory in the caller and pass that directory to Fetcher.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to