[
https://issues.apache.org/jira/browse/MESOS-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944742#comment-15944742
]
Benjamin Bannier commented on MESOS-7316:
-----------------------------------------
This is related to a cleanup of our handling of {{Flags}},
https://github.com/apache/mesos/commit/f441eb9adb.
Here we made sure that all {{Flag}} s added to some {{Flags}} instance
were always stored in a way to make the instance copyable for which we needed
to properly make them member of some {{Flags}} class. In the case here we moved
variables added out-of-band to a {{master::Flags}} instance {{master/main.cpp}}
into a dedicated, local class deriving from {{master::Flags}} to support
parsing; we did not touch e.g., code providing the endpoint which was working
with a {{master::Flags}} and exposing its members. As a result of the cleanup
users of e.g., {{master::Flags}} can access just its class members, and not
variables added out of band anymore.
We should evaluate which variables declared as members of the {{Flags}}
instance local to {{master/main.cpp}} should instead be globally accessible.
Currently the following variables are understood: {{ip}}, {{advertise_ip}},
{{advertise_port}}, {{zk}}, and {{ip_discovery_command}}.
This issue is mirrored by at least {{slave::Flags}} and the class local to
{{slave/main.cpp}} as well.
> Upgrading Mesos to 1.2.0 results in some information missing from the
> `/flags` endpoint.
> ----------------------------------------------------------------------------------------
>
> Key: MESOS-7316
> URL: https://issues.apache.org/jira/browse/MESOS-7316
> Project: Mesos
> Issue Type: Bug
> Components: HTTP API
> Reporter: Anand Mazumdar
> Priority: Critical
> Labels: mesosphere
>
> From OSS Mesos Slack:
> I recently tried upgrading one of our Mesos clusters from 1.1.0 to 1.2.0.
> After doing this, it looks like the {{zk}} field on the {{/master/flags}}
> endpoint is no longer present.
> This looks related to the recent {{Flags}} refactoring that was done which
> resulted in some flags no longer being populated since they were not part of
> {{master::Flags}} in {{src/master/flags.hpp}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
