[ 
https://issues.apache.org/jira/browse/MESOS-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joseph Wu updated MESOS-5418:
-----------------------------
    Description: 
The json command sent to the containerizer is malformed if the double quotes 
characters are not escaped on Windows. The code should be extracted in a 
separate function and a test case should be added. 

Tha command line show be similar to the following:
{code}
   CmdLine: mesos-containerizer.exe launch 
--command={\"environment\":{\"variables\":[{\"name\":\"MARATHON_APP_VERSION\",\"value\":\"2016-05-17T19:01:41.164Z\"}
,{\"name\":\"HOST\",\"value\":\"10.6.0.4\"},{\"name\":\"MARATHON_APP_RESOURCE_CPUS\",\"value\":\"0.1\"},{\"name\":\"PORT_10001\",\"value\":\"31090\"},{\"name\":
\"MESOS_TASK_ID\",\"value\":\"2.b1ab4785-1e14-11e6-8677-000d3a3000b0\"},{\"name\":\"PORT\",\"value\":\"31090\"},{\"name\":\"MARATHON_APP_RESOURCE_MEM\",\"value\
":\"128.0\"},{\"name\":\"PORTS\",\"value\":\"31090\"
{code}

  was:
The json command sent to the containerizer is malformed if the double quotes 
characters are not escaped on Windows. The code should be extracted in a 
separate function and a test case should be added. 

Tha command line show be similar to the following:
   CmdLine: mesos-containerizer.exe launch 
--command={\"environment\":{\"variables\":[{\"name\":\"MARATHON_APP_VERSION\",\"value\":\"2016-05-17T19:01:41.164Z\"}
,{\"name\":\"HOST\",\"value\":\"10.6.0.4\"},{\"name\":\"MARATHON_APP_RESOURCE_CPUS\",\"value\":\"0.1\"},{\"name\":\"PORT_10001\",\"value\":\"31090\"},{\"name\":
\"MESOS_TASK_ID\",\"value\":\"2.b1ab4785-1e14-11e6-8677-000d3a3000b0\"},{\"name\":\"PORT\",\"value\":\"31090\"},{\"name\":\"MARATHON_APP_RESOURCE_MEM\",\"value\
":\"128.0\"},{\"name\":\"PORTS\",\"value\":\"31090\"


> Test case: Escape containerizer command line on Windows
> -------------------------------------------------------
>
>                 Key: MESOS-5418
>                 URL: https://issues.apache.org/jira/browse/MESOS-5418
>             Project: Mesos
>          Issue Type: Task
>         Environment: Windows
>            Reporter: Daniel Pravat
>            Assignee: Andrew Schwartzmeyer
>            Priority: Minor
>             Fix For: 1.3.0
>
>
> The json command sent to the containerizer is malformed if the double quotes 
> characters are not escaped on Windows. The code should be extracted in a 
> separate function and a test case should be added. 
> Tha command line show be similar to the following:
> {code}
>    CmdLine: mesos-containerizer.exe launch 
> --command={\"environment\":{\"variables\":[{\"name\":\"MARATHON_APP_VERSION\",\"value\":\"2016-05-17T19:01:41.164Z\"}
> ,{\"name\":\"HOST\",\"value\":\"10.6.0.4\"},{\"name\":\"MARATHON_APP_RESOURCE_CPUS\",\"value\":\"0.1\"},{\"name\":\"PORT_10001\",\"value\":\"31090\"},{\"name\":
> \"MESOS_TASK_ID\",\"value\":\"2.b1ab4785-1e14-11e6-8677-000d3a3000b0\"},{\"name\":\"PORT\",\"value\":\"31090\"},{\"name\":\"MARATHON_APP_RESOURCE_MEM\",\"value\
> ":\"128.0\"},{\"name\":\"PORTS\",\"value\":\"31090\"
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to