[
https://issues.apache.org/jira/browse/MESOS-7464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000081#comment-16000081
]
Neil Conway commented on MESOS-7464:
------------------------------------
It seems like Docker has switched from using Semver to using a date-based
versioning scheme --
https://github.com/moby/moby/blob/master/CHANGELOG.md#17030-ce-2017-03-01
As it happens, the previous implementation of Semver in stout was not very
strict (in conflict with what the Semver spec requires), and hence it did not
reject version numbers with leading zeros. The commit mentioned above changed
this; we now reject version numbers with leading zeros, which breaks on recent
versions of Docker. But note that Docker is not using Semver anymore anyway, so
it seems wrong to be trying to parse Docker versions using Semver in the first
place.
Seems like we have a few options:
# Remove the "leading zero" check from stout's {{Version}} class. This is
inconsistent with the Semver spec, although allowing more input formats is
probably acceptable.
# Don't use stout's {{Version}} to parse Docker version's, and instead use some
custom parsing/comparison logic.
# Add another Version-like abstraction to stout that accepts a more relaxed
input format.
> Regression: Windows docker container could not be launched any more
> -------------------------------------------------------------------
>
> Key: MESOS-7464
> URL: https://issues.apache.org/jira/browse/MESOS-7464
> Project: Mesos
> Issue Type: Bug
> Components: docker
> Affects Versions: 1.4.0
> Reporter: Li Li
> Assignee: Neil Conway
>
> With the latest agent logic, the windows docker container cannot be launched
> anymore. This is regression caused by After investigation, the regression is
> caused by SHA1 ID: 287556284d76e03c11cff3fc076224fe966096e0.
> With the above checkin, windows docker version: 17.03.0-ee-1 is rejected with
> error returned since "03" is with leading zero.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
