[
https://issues.apache.org/jira/browse/MESOS-7817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095177#comment-16095177
]
Michael Park commented on MESOS-7817:
-------------------------------------
{noformat}
commit cce7f5f6e8bea0972dab003cd84959d044350f5f
Author: Andrew Schwartzmeyer <[email protected]>
Date: Thu Jul 20 11:35:07 2017 -0700
Windows: Fixed `CreateProcess` error message.
The buffer conversion of the argument string was being printed instead
of the argument string itself, leading to an error message with a bunch
of bytes.
Review: https://reviews.apache.org/r/61001/
{noformat}
> CreateProcess wrapper's error message is bad
> --------------------------------------------
>
> Key: MESOS-7817
> URL: https://issues.apache.org/jira/browse/MESOS-7817
> Project: Mesos
> Issue Type: Bug
> Components: stout
> Environment: Windows 10
> Reporter: Andrew Schwartzmeyer
> Assignee: Andrew Schwartzmeyer
> Priority: Trivial
> Labels: stout, windows
>
> In stout/os/windows/shell.hpp: Try<ProcessData> create_process(...) wrapper:
> We have an `arg_string` and an `arg_buffer` because of oddities of
> `CreateProcessW`. But when composing the error message we need to use the
> string, not the buffer. Otherwise stringify kindly outputs a massive array of
> bytes. Currently by mistake we use the buffer, probably due to a renaming
> refactor I did.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
