[ 
https://issues.apache.org/jira/browse/MESOS-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102754#comment-16102754
 ] 

Qian Zhang commented on MESOS-6115:
-----------------------------------

commit e6ec4e8362552cbaf74bf3e844e7ac4b15f9aafd (origin/master, origin/HEAD, 
master)
Author: Qian Zhang [email protected]
Date:   Thu Jul 27 09:45:48 2017 +0800

Generated protobuf_tests.pb.* files during the build.

Review: https://reviews.apache.org/r/60109/

> Source tree contains compiled protobuf source
> ---------------------------------------------
>
>                 Key: MESOS-6115
>                 URL: https://issues.apache.org/jira/browse/MESOS-6115
>             Project: Mesos
>          Issue Type: Bug
>          Components: stout, test
>            Reporter: Benjamin Bannier
>            Assignee: Qian Zhang
>              Labels: mesosphere, newbie
>             Fix For: 1.4.0
>
>
> Stout's {{protobuf_tests.cpp}} uses checked in, generated protobuf files 
> {{protobuf_tests.pb.h}} and {{protobuf_tests.pb.cc}}.
> These files are
> * not meant to be edited,
> * might require updates whenever protobuf is updated, and
> * likely do not follow Mesos coding standards.
> We should try to remove them from the source tree.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to