Andrew Schwartzmeyer updated MESOS-6959:
    Comment: was deleted

(was: -We can pretty easily replace this with 

> Separate the mesos-containerizer binary into a static binary, which only 
> depends on stout
> -----------------------------------------------------------------------------------------
>                 Key: MESOS-6959
>                 URL: https://issues.apache.org/jira/browse/MESOS-6959
>             Project: Mesos
>          Issue Type: Task
>          Components: cmake
>            Reporter: Joseph Wu
>            Assignee: Andrew Schwartzmeyer
>              Labels: cmake, mesosphere, microsoft
> The {{mesos-containerizer}} binary currently has [three 
> commands|https://github.com/apache/mesos/blob/6cf3a94a52e87a593c9cba373bf433cfc4178639/src/slave/containerizer/mesos/main.cpp#L46-L48]:
> * 
> [MesosContainerizerLaunch|https://github.com/apache/mesos/blob/6cf3a94a52e87a593c9cba373bf433cfc4178639/src/slave/containerizer/mesos/launch.cpp]
> * 
> [MesosContainerizerMount|https://github.com/apache/mesos/blob/6cf3a94a52e87a593c9cba373bf433cfc4178639/src/slave/containerizer/mesos/mount.cpp]
> * 
> [NetworkCniIsolatorSetup|https://github.com/apache/mesos/blob/6cf3a94a52e87a593c9cba373bf433cfc4178639/src/slave/containerizer/mesos/isolators/network/cni/cni.cpp#L1776-L1997]
> These commands are all heavily dependent on stout, and have no need to be 
> linked to libprocess.  In fact, adding an erroneous call to 
> {{process::initialize}} (either explicitly, or by accidentally using a 
> libprocess method) will break {{mesos-containerizer}} can cause several Mesos 
> containerizer tests to fail.  (The tasks fail to launch, saying {{Failed to 
> synchronize with agent (it's probably exited)}}).
> Because this binary only depends on stout, we can separate it from the other 
> source files and make this a static binary.

This message was sent by Atlassian JIRA

Reply via email to