[
https://issues.apache.org/jira/browse/MESOS-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126392#comment-16126392
]
Greg Mann commented on MESOS-7660:
----------------------------------
{code}
commit 2fe2bb26a425da9aaf1d7cf34019dd347d0cf9a4
Author: Gastón Kleiman <[email protected]>
Date: Mon Aug 14 13:52:54 2017 -0700
Added MESOS-7660 to the changelog.
This patch adds MESOS-7660 to the changelog and adds a missing period
to the existing text.
Review: https://reviews.apache.org/r/61621/
{code}
{code}
commit 183cceef366586f4a55b6ba7144c4a8277eb9962
Author: Gastón Kleiman <[email protected]>
Date: Mon Aug 14 13:52:52 2017 -0700
Fixed the default filter used by the allocator.
If a framework accepts/refuses an offer using a very long filter, the
`HierarchicalAllocator` will use the default filter instead, meaning
that it will filter the resources for only 5 seconds. This can happen
when a framework sets `Filter::refuse_seconds` to a number of seconds
larger than what fits in `Duration`.
This patch makes the hierarchical allocator cap the filter duration to
at most 365 days.
Review: https://reviews.apache.org/r/60525/
{code}
> HierarchicalAllocator uses the default filter instead of a very long one
> ------------------------------------------------------------------------
>
> Key: MESOS-7660
> URL: https://issues.apache.org/jira/browse/MESOS-7660
> Project: Mesos
> Issue Type: Bug
> Components: allocation
> Reporter: Gastón Kleiman
> Assignee: Gastón Kleiman
> Labels: mesosphere
> Fix For: 1.5.0
>
>
> If a framework accepts/refuses an offer using a very long filter, [the
> {{HierarchicalAllocator}} will use the default {{Filter}}
> instead|https://github.com/apache/mesos/blob/master/src/master/allocator/mesos/hierarchical.cpp#L1046-L1052].
> Meaning that it will filter the resources for only 5 seconds.
> This can happen when a framework sets {{Filter::refuse_seconds}} to a number
> of seconds [larger than what fits in
> {{Duration}}|https://github.com/apache/mesos/blob/13cae29e7832d8bb879c68847ad0df449d227f17/3rdparty/stout/include/stout/duration.hpp#L401-L405].
> The following [tests are
> flaky|https://issues.apache.org/jira/browse/MESOS-7514] because of this:
> {{ReservationTest.ReserveShareWithinRole}} and
> {{ReservationTest.PreventUnreservingAlienResources}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
