[ 
https://issues.apache.org/jira/browse/MESOS-7306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145539#comment-16145539
 ] 

Jie Yu edited comment on MESOS-7306 at 8/29/17 4:00 PM:
--------------------------------------------------------


commit 9645d5184f08c6df3fa5325af5aaf1b0bdf5f612
Author: Jie Yu <[email protected]>
Date:   Sat Aug 26 13:19:15 2017 -0700

    Parameterized the volume host path tests on executor type.

    This allows us to test the isolator when the container is a normal
    container (command executor) or a nested container (default executor).

    Review: https://reviews.apache.org/r/61929

commit 8858df48abb52fb56dd86859d7efd373cd09d5f8
Author: Jie Yu <[email protected]>
Date:   Fri Aug 25 15:19:11 2017 -0700

    Adjusted the test helpers for creating host and sandbox path volumes.

    Previously, we used the same helper for creating both host and sandbox
    path volumes. This patch split that into two separate helpers.

    Review: https://reviews.apache.org/r/61919

commit 8340b23917a1c6eceefa2fddf5dfc3c446e27933
Author: Jie Yu <[email protected]>
Date:   Thu Aug 24 16:52:29 2017 -0700

    Used path::absolute to replace some startsWith checks.

    Review: https://reviews.apache.org/r/61908

commit 5e179c969193df4d2d1cc88c4c7826d20a29c262
Author: Jie Yu <[email protected]>
Date:   Thu Aug 24 16:17:09 2017 -0700

    Moved host volume related tests to a dedicated file.

    Review: https://reviews.apache.org/r/61907

commit 23d31656b8965c3ca9b9bc753f33a09dab5b1949
Author: Jie Yu <[email protected]>
Date:   Thu Aug 24 14:27:33 2017 -0700

    Added a dependency check 'filesystem/linux' isolator.

    The 'filesystem/linux' isolator depends on 'linux' launcher to create
    the mount namespace. Therefore, we add this dependency check and try
    to fail early.

    Review: https://reviews.apache.org/r/61906

commit 2622badedef856810db9a8a274a3eff6eb6231cf
Author: Jie Yu <[email protected]>
Date:   Thu Aug 24 12:37:18 2017 -0700

    Integrated 'volume/host_path' into MesosContainerizer.

    This patch removed the host volume logics from the 'filesystem/linux'
    isolator, and integrated the new 'volume/host_path' isolator. For
    backward compatibility, we always enable 'volume/host_path' isolator
    if 'filesystem/linux' isolator is enabled.

    Review: https://reviews.apache.org/r/61905

commit faa8aae51f893b8a55c29345e2c3cffbcadfcf29
Author: Jie Yu <[email protected]>
Date:   Sun Aug 20 16:46:04 2017 -0700

    Added volume/host_path isolator.

    This isolator will be used to handle HOST_PATH volumes. The goal is to
    move the logics of handling host volumes from the linux filesystem
    isolator to this dedicated isolator to make the code more modular.

    Review: https://reviews.apache.org/r/61904

commit ad363f1fe94bc491d2b5dc95986aa9839f3bb815
Author: Jie Yu <[email protected]>
Date:   Sun Aug 20 16:45:22 2017 -0700

    Fixed a indentation issue in linux filesystem isolator.

    Review: https://reviews.apache.org/r/61903

commit f973d30a8e6b4f95275f2873087cccc9eef97150
Author: Jie Yu <[email protected]>
Date:   Sun Aug 20 16:44:15 2017 -0700

    Added master and agent validation for ContainerInfo.

    Review: https://reviews.apache.org/r/61902

commit 0d14817681c8e48f8f1cc162845226433c385ddd
Author: Jie Yu <[email protected]>
Date:   Sun Aug 20 16:37:46 2017 -0700

    Added common validation for Volume.

    Review: https://reviews.apache.org/r/61901

commit 6a5d99ae8c496178c6cbcf737f93775c28d7a6a6
Author: Jie Yu <[email protected]>
Date:   Sun Aug 20 16:34:11 2017 -0700

    Added equal operator for Error.

    Review: https://reviews.apache.org/r/61900

commit e0e62f63d2c3ee5f94e12aa436dddfb77faf4a63
Author: Jie Yu <[email protected]>
Date:   Tue Aug 1 17:05:33 2017 -0700

    Added HOST_PATH volume source protobuf.

    Review: https://reviews.apache.org/r/61899


was (Author: jieyu):
Last login: Sun Aug 27 16:55:14 on ttys000
Jies-MacBook-Pro:~ jie$ ls
Applications   Documents      Dropbox        Library        Music          
Public         workspace
Desktop        Downloads      Google Drive   Movies         Pictures       
VirtualBox VMs
Jies-MacBook-Pro:~ jie$ ls
Applications   Documents      Dropbox        Library        Music          
Public         workspace
Desktop        Downloads      Google Drive   Movies         Pictures       
VirtualBox VMs
Jies-MacBook-Pro:~ jie$ tmux








































commit 9645d5184f08c6df3fa5325af5aaf1b0bdf5f612
Author: Jie Yu <[email protected]>
Date:   Sat Aug 26 13:19:15 2017 -0700

    Parameterized the volume host path tests on executor type.

    This allows us to test the isolator when the container is a normal
    container (command executor) or a nested container (default executor).

    Review: https://reviews.apache.org/r/61929

commit 8858df48abb52fb56dd86859d7efd373cd09d5f8
Author: Jie Yu <[email protected]>
Date:   Fri Aug 25 15:19:11 2017 -0700

    Adjusted the test helpers for creating host and sandbox path volumes.

    Previously, we used the same helper for creating both host and sandbox
    path volumes. This patch split that into two separate helpers.

    Review: https://reviews.apache.org/r/61919

commit 8340b23917a1c6eceefa2fddf5dfc3c446e27933
Author: Jie Yu <[email protected]>
Date:   Thu Aug 24 16:52:29 2017 -0700

    Used path::absolute to replace some startsWith checks.

    Review: https://reviews.apache.org/r/61908

commit 5e179c969193df4d2d1cc88c4c7826d20a29c262
Author: Jie Yu <[email protected]>
Date:   Thu Aug 24 16:17:09 2017 -0700

    Moved host volume related tests to a dedicated file.

    Review: https://reviews.apache.org/r/61907

commit 23d31656b8965c3ca9b9bc753f33a09dab5b1949
Author: Jie Yu <[email protected]>
Date:   Thu Aug 24 14:27:33 2017 -0700

    Added a dependency check 'filesystem/linux' isolator.

    The 'filesystem/linux' isolator depends on 'linux' launcher to create
    the mount namespace. Therefore, we add this dependency check and try
    to fail early.

    Review: https://reviews.apache.org/r/61906

commit 2622badedef856810db9a8a274a3eff6eb6231cf
Author: Jie Yu <[email protected]>
Date:   Thu Aug 24 12:37:18 2017 -0700

    Integrated 'volume/host_path' into MesosContainerizer.

    This patch removed the host volume logics from the 'filesystem/linux'
    isolator, and integrated the new 'volume/host_path' isolator. For
    backward compatibility, we always enable 'volume/host_path' isolator
    if 'filesystem/linux' isolator is enabled.

    Review: https://reviews.apache.org/r/61905

commit faa8aae51f893b8a55c29345e2c3cffbcadfcf29
Author: Jie Yu <[email protected]>
Date:   Sun Aug 20 16:46:04 2017 -0700

    Added volume/host_path isolator.

    This isolator will be used to handle HOST_PATH volumes. The goal is to
    move the logics of handling host volumes from the linux filesystem
    isolator to this dedicated isolator to make the code more modular.

    Review: https://reviews.apache.org/r/61904

commit ad363f1fe94bc491d2b5dc95986aa9839f3bb815
Author: Jie Yu <[email protected]>
Date:   Sun Aug 20 16:45:22 2017 -0700

    Fixed a indentation issue in linux filesystem isolator.

    Review: https://reviews.apache.org/r/61903

commit f973d30a8e6b4f95275f2873087cccc9eef97150
Author: Jie Yu <[email protected]>
Date:   Sun Aug 20 16:44:15 2017 -0700

    Added master and agent validation for ContainerInfo.

    Review: https://reviews.apache.org/r/61902

commit 0d14817681c8e48f8f1cc162845226433c385ddd
Author: Jie Yu <[email protected]>
Date:   Sun Aug 20 16:37:46 2017 -0700

    Added common validation for Volume.

    Review: https://reviews.apache.org/r/61901

commit 6a5d99ae8c496178c6cbcf737f93775c28d7a6a6
Author: Jie Yu <[email protected]>
Date:   Sun Aug 20 16:34:11 2017 -0700

    Added equal operator for Error.

    Review: https://reviews.apache.org/r/61900

commit e0e62f63d2c3ee5f94e12aa436dddfb77faf4a63
Author: Jie Yu <[email protected]>
Date:   Tue Aug 1 17:05:33 2017 -0700

    Added HOST_PATH volume source protobuf.

    Review: https://reviews.apache.org/r/61899

> Support mount propagation for host volumes.
> -------------------------------------------
>
>                 Key: MESOS-7306
>                 URL: https://issues.apache.org/jira/browse/MESOS-7306
>             Project: Mesos
>          Issue Type: Improvement
>          Components: containerization
>            Reporter: Jie Yu
>            Assignee: Jie Yu
>              Labels: mesosphere, storage
>
> Currently, all mounts in a container are marked as 'slave' by default. 
> However, for some cases, we may want mounts under certain directory in a 
> container to be propagate back to the root mount namespace. This is useful 
> for the case where we want the mounts to survive container failures.
> See more documentation about mount propagation in:
> https://www.kernel.org/doc/Documentation/filesystems/sharedsubtree.txt
> Given mount propagation is very hard for users to understand, probably worth 
> limiting this to just host volumes because we only see use case for that at 
> the moment.
> Some relevant discussion can be found here:
> https://github.com/kubernetes/community/blob/master/contributors/design-proposals/propagation.md



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to