[ 
https://issues.apache.org/jira/browse/MESOS-6918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158964#comment-16158964
 ] 

James Peach commented on MESOS-6918:
------------------------------------

{quote}
I understand that complex Prometheus metric types such as summary require some 
more data than what is currently provided so we need to add them somewhere. But 
they should be added to Mesos' existing "core" metrics classes only if they are 
generic (backwards compatible) improvements that make sense regardless of the 
Prometheus support. I believe this is indeed your goal but we need to 
articulate how current timer/statistics modeling is lacking/wrong.
{quote}

The {{Statistics}} class currently generates enough information to support 
Prometheus summary metrics. I added some discussion about {{Timer}} metrics to 
the doc.

{quote}
There are some patches that remove history from simple metrics because it 
doesn't make sense. Should the history then be put in another base type that 
Counter and Gauge don't derive from?
{quote}

I don't see any need for that right now.

{quote}
After the above is done, is Prometheus merely a specific format? If that's the 
case, can we encapsulate the formatting logic into a formatter class/method 
instead of the main metric endpoint actor?
{quote}

Yes we might be able to do something along those lines.

> Prometheus exporter endpoints for metrics
> -----------------------------------------
>
>                 Key: MESOS-6918
>                 URL: https://issues.apache.org/jira/browse/MESOS-6918
>             Project: Mesos
>          Issue Type: Bug
>          Components: statistics
>            Reporter: James Peach
>            Assignee: James Peach
>
> There are a couple of [Prometheus|https://prometheus.io] metrics exporters 
> for Mesos, of varying quality. Since the Mesos stats system actually knows 
> about statistics data types and semantics, and Mesos has reasonable HTTP 
> support we could add Prometheus metrics endpoints to directly expose 
> statistics in [Prometheus wire 
> format|https://prometheus.io/docs/instrumenting/exposition_formats/], 
> removing the need for operators to run separate exporter processes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to