[
https://issues.apache.org/jira/browse/MESOS-7993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174070#comment-16174070
]
Andrew Schwartzmeyer commented on MESOS-7993:
---------------------------------------------
Just to have it documented here too, this is the official say on this
admittedly strange pattern:
https://msdn.microsoft.com/en-us/library/windows/desktop/ms738562(v=vs.85).aspx
> Fix Windows header orderings
> ----------------------------
>
> Key: MESOS-7993
> URL: https://issues.apache.org/jira/browse/MESOS-7993
> Project: Mesos
> Issue Type: Bug
> Components: libprocess, stout
> Environment: Windows 10
> Reporter: Andrew Schwartzmeyer
> Assignee: Andrew Schwartzmeyer
> Labels: windows
>
> On Windows it is imperative to include headers such as {{winsock2.h}}
> strictly before {{windows.h}}. Unfortunately, we don't always do this. Also,
> we erroneously include headers such as {{winsock.h}} even though we're using
> {{winsock2.h}}. A reasonable solution would be to consolidate Windows system
> headers into {{<stout/windows.hpp>}}, and include it where particular (and
> troublesome) system headers need to be included.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)