[
https://issues.apache.org/jira/browse/MESOS-7886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224609#comment-16224609
]
Matthew Mead-Briggs commented on MESOS-7886:
--------------------------------------------
[~vinodkone] here's the ticket that we discussed at MesosCon.
I'm going to be rolling this approach out at Yelp pretty soon. The diff above
is heavily inspired by the hook for setting task labels. After your talk I was
thinking about how I would get the volume based secrets working too. I wonder
if it makes sense to have a hook that just allows the user to override the
whole TaskInfo object? Rather than a hook for each thing within it. Its a
longer term goal anyway as it'll only be easy if we move to the Mesos
containerizer. Maybe you have some better ideas about how we could hook secret
resolvers into the master side more properly?
> Add master hook for setting environment variables
> -------------------------------------------------
>
> Key: MESOS-7886
> URL: https://issues.apache.org/jira/browse/MESOS-7886
> Project: Mesos
> Issue Type: Improvement
> Components: modules
> Reporter: Matthew Mead-Briggs
>
> At Yelp we're planning to integrate our secret store with our platform as a
> service which runs on Mesos.
> I was hoping to write a module to "inject" environment variables on the
> master side but the necessary hook doesn't currently exist. Such a hook
> already exists on the slave side. However, for this integration that would
> require me to give all the agents access to the secret store and I'd much
> prefer to limit this to the master side.
> There is already a hook for adding labels:
> https://github.com/apache/mesos/blob/72752fc6deb8ebcbfbd5448dc599ef3774339d31/include/mesos/hook.hpp#L44-L48
> So it seems it should be pretty easy to add one for setting environment
> variables too? I had a crack the other day but although I got my code to
> compile something was not working at runtime (note: I'm not a C++ dev). Is
> there any reason why we wouldn't want such a hook? If anyone can confirm that
> it's a sane thing to add then I'd be happy to spend some time trying to get
> it working (although I may need some help)!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
