[
https://issues.apache.org/jira/browse/MESOS-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245903#comment-16245903
]
Kevin Klues edited comment on MESOS-7924 at 11/9/17 4:01 PM:
-------------------------------------------------------------
{noformat}
commit 844590611067d04de86a2de923b21ef377554728
Author: Armand Grillet <[email protected]>
Date: Thu Nov 9 16:53:40 2017 +0100
Added JavaScript linter.
The linter runs when changes on a JavaScript file are being committed.
We use ESLint with a configuration based on our current JS code base.
The linter and its dependencies (i.e. Node.js) are installed in a
virtual environment using Virtualenv and then Nodeenv.
Review: https://reviews.apache.org/r/62214/
{noformat}
was (Author: klueska):
{noformat}
commit 844590611067d04de86a2de923b21ef377554728 (HEAD -> master,
upstream/master)
Author: Armand Grillet <[email protected]>
Date: Thu Nov 9 16:53:40 2017 +0100
Added JavaScript linter.
The linter runs when changes on a JavaScript file are being committed.
We use ESLint with a configuration based on our current JS code base.
The linter and its dependencies (i.e. Node.js) are installed in a
virtual environment using Virtualenv and then Nodeenv.
Review: https://reviews.apache.org/r/62214/
{noformat}
> Add a javascript linter to the webui.
> -------------------------------------
>
> Key: MESOS-7924
> URL: https://issues.apache.org/jira/browse/MESOS-7924
> Project: Mesos
> Issue Type: Improvement
> Components: webui
> Reporter: Benjamin Mahler
> Assignee: Armand Grillet
> Labels: tech-debt
> Fix For: 1.5.0
>
>
> As far as I can tell, javascript linters (e.g. ESLint) help catch some
> functional errors as well, for example, we've made some "strict" mistakes a
> few times that ESLint can catch: MESOS-6624, MESOS-7912.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
