[
https://issues.apache.org/jira/browse/MESOS-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247536#comment-16247536
]
Kevin Klues commented on MESOS-7924:
------------------------------------
{noformat}
commit f03e75c98b67d2e610bbd5eae366f7b206306399
Author: Armand Grillet <[email protected]>
Date: Fri Nov 10 14:50:15 2017 +0100
Updated JavaScript linter rules.
The rules we added do the following:
1. They force us to use 'this_' for any alias of 'this'
that we create.
2. They allow us to have arguments to functions that go unused so long
as the variable names begin with an '_'.
Review: https://reviews.apache.org/r/63724/
{noformat}
{noformat}
commit af8404e7bf49201d7f3a0a563f43d767539558f0
Author: Armand Grillet <[email protected]>
Date: Fri Nov 10 14:52:43 2017 +0100
Linted JavaScript files.
Review: https://reviews.apache.org/r/63703/
{noformat}
{noformat}
commit 5516adba30324bcb1a8e9aa9ab95e489663c70a4
Author: Armand Grillet <[email protected]>
Date: Fri Nov 10 15:03:10 2017 +0100
Improved support/mesos-style.py structure.
We have updated the following three things:
1. The Python linter now also use the function
`run_command_in_virtualenv` to run.
2. The methods of LinterBase have been reordered alphabetically.
3. Some unecessary excluded files have been removed for the JS linter.
Review: https://reviews.apache.org/r/63585/
{noformat}
> Add a javascript linter to the webui.
> -------------------------------------
>
> Key: MESOS-7924
> URL: https://issues.apache.org/jira/browse/MESOS-7924
> Project: Mesos
> Issue Type: Improvement
> Components: webui
> Reporter: Benjamin Mahler
> Assignee: Armand Grillet
> Labels: tech-debt
> Fix For: 1.5.0
>
>
> As far as I can tell, javascript linters (e.g. ESLint) help catch some
> functional errors as well, for example, we've made some "strict" mistakes a
> few times that ESLint can catch: MESOS-6624, MESOS-7912.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
