[
https://issues.apache.org/jira/browse/MESOS-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275165#comment-16275165
]
Yan Xu commented on MESOS-8200:
-------------------------------
{noformat:title=}
commit 3711233fcec761be8625af6a028a228fe9d8dc5a
Author: Jiang Yan Xu <[email protected]>
Date: Fri Nov 10 12:15:37 2017 -0800
Fixed 'NoOffersWithAllRolesSuppressed' test.
Review: https://reviews.apache.org/r/63830
commit 5d9209e69a0a9600ec8c02fbf852ab912b208a88
Author: Jiang Yan Xu <[email protected]>
Date: Fri Nov 10 12:16:45 2017 -0800
Fixed a bug in devolving framework subscription with suppressed roles.
Review: https://reviews.apache.org/r/63741
{noformat}
> Suppressed roles are not honoured for v1 scheduler subscribe requests.
> ----------------------------------------------------------------------
>
> Key: MESOS-8200
> URL: https://issues.apache.org/jira/browse/MESOS-8200
> Project: Mesos
> Issue Type: Bug
> Components: scheduler api, scheduler driver
> Affects Versions: 1.4.0
> Reporter: Alexander Rukletsov
> Assignee: Yan Xu
> Priority: Critical
> Fix For: 1.5.0
>
>
> When triaging MESOS-7996 I've found out that
> {{Call.subscribe.suppressed_roles}} field is empty when the master processes
> the request from a v1 HTTP scheduler. More precisely, [this
> conversion|https://github.com/apache/mesos/blob/1132e1ddafa6a1a9bc8aa966bd01d7b35c7682d9/src/master/http.cpp#L969]
> wipes the field. This is likely because this conversion relies on a general
> [protobuf conversion
> utility|https://github.com/apache/mesos/blob/1132e1ddafa6a1a9bc8aa966bd01d7b35c7682d9/src/internal/devolve.cpp#L28-L50],
> which fails to copy {{suppressed_roles}} because they have different tags,
> compare
> [v0|https://github.com/apache/mesos/blob/1132e1ddafa6a1a9bc8aa966bd01d7b35c7682d9/include/mesos/scheduler/scheduler.proto#L271]
> and
> [v1|https://github.com/apache/mesos/blob/1132e1ddafa6a1a9bc8aa966bd01d7b35c7682d9/include/mesos/v1/scheduler/scheduler.proto#L258].
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
