[
https://issues.apache.org/jira/browse/MESOS-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297244#comment-16297244
]
Alexander Rukletsov edited comment on MESOS-8267 at 12/20/17 2:03 PM:
----------------------------------------------------------------------
{noformat}
Commit: 0cc636b2d5ad5c934b8b7f350bc8c99b9282b5ab [0cc636b]
Author: Andrei Budnik <[email protected]>
Date: 19 December 2017 at 19:45:33 GMT+1
Committer: Alexander Rukletsov <[email protected]>
Fixed flaky `ROOT_CGROUPS_RecoverLauncherOrphans` test.
Containerizer recovery returns control to the caller before completion
of destruction of orphaned containers. Previously, `wait` was called on
a container right after calling `recover`, so `wait` was almost always
successfull, because destruction of the orphaned container takes some
time to complete.
This patch replaces check for the container existence with the check
that a related freezer cgroup has been destroyed. The freezer cgroup
is destroyed during container destruction initiated by a containerizer
recovery process.
Review: https://reviews.apache.org/r/64680/
{noformat}
{noformat}
Commit: 196fe20861a4efc8edcabb08ce8821e8ed1b8f02 [196fe20]
Author: Andrei Budnik <[email protected]>
Date: 20 December 2017 at 14:59:50 GMT+1
Committer: Alexander Rukletsov <[email protected]>
Fixed flaky `NestedMesosContainerizerTest` tests.
This patch is an addition to commit 0cc636b2d5.
Review: https://reviews.apache.org/r/64749/
{noformat}
was (Author: alexr):
{noformat}
Commit: 0cc636b2d5ad5c934b8b7f350bc8c99b9282b5ab [0cc636b]
Author: Andrei Budnik <[email protected]>
Date: 19 December 2017 at 19:45:33 GMT+1
Committer: Alexander Rukletsov <[email protected]>
Fixed flaky `ROOT_CGROUPS_RecoverLauncherOrphans` test.
Containerizer recovery returns control to the caller before completion
of destruction of orphaned containers. Previously, `wait` was called on
a container right after calling `recover`, so `wait` was almost always
successfull, because destruction of the orphaned container takes some
time to complete.
This patch replaces check for the container existence with the check
that a related freezer cgroup has been destroyed. The freezer cgroup
is destroyed during container destruction initiated by a containerizer
recovery process.
Review: https://reviews.apache.org/r/64680/
{noformat}
> NestedMesosContainerizerTest.ROOT_CGROUPS_RecoverLauncherOrphans is flaky.
> --------------------------------------------------------------------------
>
> Key: MESOS-8267
> URL: https://issues.apache.org/jira/browse/MESOS-8267
> Project: Mesos
> Issue Type: Bug
> Components: test
> Environment: Ubuntu 16.04
> Reporter: Alexander Rukletsov
> Assignee: Andrei Budnik
> Labels: flaky-test
> Fix For: 1.5.0
>
> Attachments: ROOT_CGROUPS_RecoverLauncherOrphans-badrun.txt
>
>
> {noformat}
> ../../src/tests/containerizer/nested_mesos_containerizer_tests.cpp:1902
> wait.get() is NONE
> {noformat}
> Full log attached.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
