[ 
https://issues.apache.org/jira/browse/MESOS-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301268#comment-16301268
 ] 

Alexander Rukletsov commented on MESOS-8297:
--------------------------------------------

{noformat}
Commit: 44a702a1b26963040e6cb6c362b7f01e5b4ef097 [44a702a]
Author: Alexander Rukletsov [email protected]
Date: 22 December 2017 at 12:09:58 GMT+1
Committer: Alexander Rukletsov [email protected]

Promoted log level to warning for disconnected events in exec.cpp.

When the executor library receives messages while being disconnected,
it might indicate an out-of-order message delivery or lost messages.
This should be logged at the warning level to simplify triaging.

Review: https://reviews.apache.org/r/64032/
{noformat}
{noformat}
Commit: 47392cf9f9024718550c69bcef9319560b47d5c7 [47392cf]
Author: Alexander Rukletsov <[email protected]>
Date: 22 December 2017 at 12:10:15 GMT+1
Committer: Alexander Rukletsov <[email protected]>

Ensured command executor always honors shutdown request.

Review: https://reviews.apache.org/r/64069/
{noformat}
{noformat}
Commit: b2eddcfe0ede4725208ae33c8c7f56563ff10514 [b2eddcf]
Author: Alexander Rukletsov <[email protected]>
Date: 22 December 2017 at 12:10:28 GMT+1
Committer: Alexander Rukletsov <[email protected]>

Ensured executor adapter propagates error and shutdown messages.

Prior to this patch, if an error, kill, or shutdown occurred during
subscription / registration with the agent, it was not propagated back
to the executor if the v0_v1 executor adapter was used. This happened
because the adapter did not call the `connected` callback until after
successful registration and hence the executor did not even try to
send the `SUBSCRIBE` call, without which the adapter did not send any
events to the executor.

A fix is to call the `connected` callback if an error occurred or
shutdown / kill event arrived before the executor had subscribed.

Review: https://reviews.apache.org/r/64070/
{noformat}
{noformat}
Commit: 769108e94a7c7834c44e01091a9940354eb3f6e4 [769108e]
Author: Alexander Rukletsov <[email protected]>
Date: 22 December 2017 at 12:10:35 GMT+1
Committer: Alexander Rukletsov <[email protected]>

Terminated driver-based executors if kill arrives before launch task.

`ExecutorRegisteredMessage` or `RunTaskMessage` may not be delivered
to a driver-based executor. Since these messages are not retried,
without this patch an executor never starts a task and remains idle,
ignoring kill task request. This patch ensures all built-in driver-
based executors eventually shut down if kill task arrives before
the task has been started.

Review: https://reviews.apache.org/r/64033/
{noformat}

> Built-in driver-based executors ignore kill task if the task has not been 
> launched.
> -----------------------------------------------------------------------------------
>
>                 Key: MESOS-8297
>                 URL: https://issues.apache.org/jira/browse/MESOS-8297
>             Project: Mesos
>          Issue Type: Bug
>          Components: executor
>            Reporter: Alexander Rukletsov
>            Assignee: Alexander Rukletsov
>            Priority: Blocker
>              Labels: mesosphere
>
> If docker executor receives a kill task request and the task has never been 
> launch, the request is ignored. We now know that: the executor has never 
> received the registration confirmation, hence has ignored the launch task 
> request, hence the task has never started. And this is how the executor 
> enters an idle state, waiting for registration and ignoring kill task 
> requests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to