[
https://issues.apache.org/jira/browse/MESOS-7342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329733#comment-16329733
]
Andrew Schwartzmeyer commented on MESOS-7342:
---------------------------------------------
{noformat}
commit 8964137f6 (HEAD -> master, apache/master, apache/HEAD)
Author: Akash Gupta <[email protected]>
Date: Wed Jan 17 13:51:59 2018 -0800
Windows: Updated networking documentation.
The networking docs now describe how the Docker network modes in the
`Network` enum work on Windows, since the enum only has Linux network
modes.
Review: https://reviews.apache.org/r/63861/
commit 6b35c93ba
Author: Akash Gupta <[email protected]>
Date: Wed Jan 17 13:51:44 2018 -0800
Windows: Mapped the Docker network info types.
The Network enum in DockerInfo is specific to Linux containers. `HOST`
doesn't exist on Windows and `BRIDGE` is `NAT` on Windows. The current
default docker network setting was always `HOST`, which broke the
Windows docker executor. Now, if a specific network isn't given, the
network mode will default to `HOST` on Linux agents and `NAT` on Windows
agents. Also, `BRIDGE` mode will be translated to `NAT` on Windows.
Review: https://reviews.apache.org/r/63860/
commit eccd0a9f9
Author: Akash Gupta <[email protected]>
Date: Wed Jan 17 13:51:32 2018 -0800
Windows: Fixed mock signal values in stout.
Removed `SIGSTOP` and `SIGCONT` on Windows, since they are meaningless,
and never unused. Also, fixed the WEXITSTATUS macro to cast the exit
code instead of bit-masking it, since Windows exit codes are 32 bit
unsigned ints.
Review: https://reviews.apache.org/r/63859/
{noformat}
> Port Docker tests
> -----------------
>
> Key: MESOS-7342
> URL: https://issues.apache.org/jira/browse/MESOS-7342
> Project: Mesos
> Issue Type: Bug
> Components: docker
> Environment: Windows 10
> Reporter: Andrew Schwartzmeyer
> Assignee: Akash Gupta
> Priority: Major
> Labels: microsoft, windows
>
> While one of Daniel Pravat's last acts was introducing the the Docker
> containerizer for Windows, we don't have tests. We need to port
> `docker_tests.cpp` and `docker_containerizer_tests.cpp` to Windows.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
