[ 
https://issues.apache.org/jira/browse/MESOS-8482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Bannier reassigned MESOS-8482:
---------------------------------------

       Shepherd: Benjamin Bannier
       Assignee: Benno Evers
    Component/s: test

Review: https://reviews.apache.org/r/65308/

> Signed/Unsigned comparisons in tests
> ------------------------------------
>
>                 Key: MESOS-8482
>                 URL: https://issues.apache.org/jira/browse/MESOS-8482
>             Project: Mesos
>          Issue Type: Bug
>          Components: test
>            Reporter: Benno Evers
>            Assignee: Benno Evers
>            Priority: Major
>              Labels: mesosphere, newbie, tech-debt
>
> Many tests in mesos currently have comparisons between signed and unsigned 
> integers, eg
> {noformat}
>     ASSERT_EQ(4, v1Response->read_file().size());
> {noformat}
> or comparisons between values of different enums, e.g. TaskState and 
> v1::TaskState:
> {noformat}
>   ASSERT_EQ(TASK_STARTING, startingUpdate->status().state());
> {noformat}
> Usually, the compiler would catch these and emit a warning, but these are 
> currently silenced because gtest headers are included using the {{-isystem}} 
> command line flag.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to