[ 
https://issues.apache.org/jira/browse/MESOS-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359004#comment-16359004
 ] 

Andrew Schwartzmeyer commented on MESOS-2995:
---------------------------------------------

This would introduce a lot of churn for practically no gain. Replacing uses of 
{{std::string}} with {{Path}} doesn't due a whole lot, as {{Path}} just ends up 
yielding a {{std::string}}. We also probably don't want to add potential 
runtime-failures (like a validity {{CHECK}}) to {{Path}}), as that should be 
handled on input (as in, sanitize the input paths, and don't hard-code paths in 
the code base; a {{CHECK}} in {{Path}} would just be a developer's catch-all).

All the methods of the {{Path}} class can probably be re-written as static 
functions in the {{path::}} namespace. There's no need to introduce an object 
here.

> Standardize use of Path 
> ------------------------
>
>                 Key: MESOS-2995
>                 URL: https://issues.apache.org/jira/browse/MESOS-2995
>             Project: Mesos
>          Issue Type: Improvement
>          Components: stout
>            Reporter: Joseph Wu
>            Priority: Minor
>              Labels: mesosphere, newbie, stout
>
> As per the discussion in MESOS-2965, the use of the Path object should be 
> standardized:
> * Functions which effectively use Paths (as strings) should instead take 
> Paths.
> * Functions which modify and return Paths (as strings) should instead return 
> Paths.
> * Extraneous uses of Path.value should be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to