[ 
https://issues.apache.org/jira/browse/MESOS-7990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359169#comment-16359169
 ] 

Jie Yu edited comment on MESOS-7990 at 2/10/18 1:05 AM:
--------------------------------------------------------

{noformat}

commit a86ff8c36532f97b6eb6b44c6f871de24afbcc4d (HEAD -> master, origin/master, 
origin/HEAD)
 Author: Jie Yu <yujie....@gmail.com>
 Date: Thu Oct 5 21:11:41 2017 -0700

Created cgroups under systemd hierarchy in LinuxLauncher.

This patch added the support for systemd hierarchy in LinuxLauncher.
 It created the same cgroup layout under the systemd hierarchy (if
 systemd is enabled) as that in the freezer hierarchy.

This can give us a bunch of benefits:
 1) systemd-cgls can list mesos container processes.
 2) systemd-cgtop can show stats for mesos containers.
 3) Avoid the pid migration issue described in MESOS-3352.

For example:

```
 [jie@core-dev ~]$ systemd-cgls
|-1 /usr/lib/systemd/systemd --system --deserialize 20|
|-mesos|
| |-8282b91a-5724-4964-a623-7c6bd68ff4ad|
| |-31737 /usr/libexec/mesos/mesos-containerizer launch|
| |-31739 mesos-default-executor --launcher_dir=/usr/libexec/mesos|
| |-mesos|
| |-8555f4af-fa4f-4c9c-aeb3-0c9f72e6a2de|
| |-31791 /usr/libexec/mesos/mesos-containerizer launch|
| |-31793 sleep 1000
 ```|

Review: [https://reviews.apache.org/r/62800]

commit 05a2909508df56253372b4fe36330339b5de00b1
 Author: Jie Yu <yujie....@gmail.com>
 Date: Thu Oct 5 20:52:38 2017 -0700

Fixed an issue for the I/O switchboard process lifetime.

We expect the I/O switchboard process to last across agent restarts
 (similar to log rotate process or executor processes). Therefore, we
 should put it into 'mesos_executor.slice' like others.

Review: [https://reviews.apache.org/r/62799]

commit 2ece53c39a3e791f6892c4a734b6d3187f184190
 Author: Jie Yu <yujie....@gmail.com>
 Date: Thu Oct 5 20:49:20 2017 -0700

Added named cgroup hierarchy support.

This patch add a helper to get the cgroup associated with the given
 pid for a named cgroup hierarchy.

Review: [https://reviews.apache.org/r/62798]

{noformat}


was (Author: jieyu):
commit a86ff8c36532f97b6eb6b44c6f871de24afbcc4d (HEAD -> master, origin/master, 
origin/HEAD)
Author: Jie Yu <yujie....@gmail.com>
Date: Thu Oct 5 21:11:41 2017 -0700

Created cgroups under systemd hierarchy in LinuxLauncher.

This patch added the support for systemd hierarchy in LinuxLauncher.
 It created the same cgroup layout under the systemd hierarchy (if
 systemd is enabled) as that in the freezer hierarchy.

This can give us a bunch of benefits:
 1) systemd-cgls can list mesos container processes.
 2) systemd-cgtop can show stats for mesos containers.
 3) Avoid the pid migration issue described in MESOS-3352.

For example:

```
 [jie@core-dev ~]$ systemd-cgls
 |-1 /usr/lib/systemd/systemd --system --deserialize 20
 |-mesos
 | |-8282b91a-5724-4964-a623-7c6bd68ff4ad
 | |-31737 /usr/libexec/mesos/mesos-containerizer launch
 | |-31739 mesos-default-executor --launcher_dir=/usr/libexec/mesos
 | |-mesos
 | |-8555f4af-fa4f-4c9c-aeb3-0c9f72e6a2de
 | |-31791 /usr/libexec/mesos/mesos-containerizer launch
 | |-31793 sleep 1000
 ```

Review: https://reviews.apache.org/r/62800

commit 05a2909508df56253372b4fe36330339b5de00b1
Author: Jie Yu <yujie....@gmail.com>
Date: Thu Oct 5 20:52:38 2017 -0700

Fixed an issue for the I/O switchboard process lifetime.

We expect the I/O switchboard process to last across agent restarts
 (similar to log rotate process or executor processes). Therefore, we
 should put it into 'mesos_executor.slice' like others.

Review: https://reviews.apache.org/r/62799

commit 2ece53c39a3e791f6892c4a734b6d3187f184190
Author: Jie Yu <yujie....@gmail.com>
Date: Thu Oct 5 20:49:20 2017 -0700

Added named cgroup hierarchy support.

This patch add a helper to get the cgroup associated with the given
 pid for a named cgroup hierarchy.

Review: https://reviews.apache.org/r/62798

> Support systemd named hierarchy (name=systemd) for Mesos Containerizer.
> -----------------------------------------------------------------------
>
>                 Key: MESOS-7990
>                 URL: https://issues.apache.org/jira/browse/MESOS-7990
>             Project: Mesos
>          Issue Type: Improvement
>          Components: containerization
>            Reporter: Jie Yu
>            Assignee: Jie Yu
>            Priority: Major
>             Fix For: 1.6.0
>
>
> Similar to docker's cgroupfs cgroup driver, we should create cgroups under 
> /sys/fs/cgroup/systemd (if it exists), and move container pid into the 
> corresponding cgroup ( /sys/fs/cgroup/systemd/mesos/<cid>).
> This can give us a bunch of benefits:
> 1) systemd-cgls can list mesos containers
> 2) systemd-cgtop can show stats for mesos containers
> ...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to