[ 
https://issues.apache.org/jira/browse/MESOS-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375226#comment-16375226
 ] 

Greg Mann edited comment on MESOS-8575 at 2/24/18 1:52 AM:
-----------------------------------------------------------

{code}
commit a20a317765d4c577e3d7140e4d7a9b7c5bc85a56
Author: Greg Mann <[email protected]>
Date:   Fri Feb 23 16:41:46 2018 -0800

    Updated discard handling for Docker 'stop' and 'pull' commands.

    Review: https://reviews.apache.org/r/65787/
{code}
{code}
commit 9a414ab2f9dcaa599afa2ef3d5dd38e66e0258c7
Author: Greg Mann <[email protected]>
Date:   Fri Feb 23 16:41:44 2018 -0800

    Prevented Docker library from terminating incorrect processes.

    Previously, the Docker library might call `os::killtree()` on a
    PID after the associated subprocess had already terminated, which
    could lead to an unknown process being incorrectly killed.

    Review: https://reviews.apache.org/r/65786/
{code}


was (Author: greggomann):
{code}
commit a20a317765d4c577e3d7140e4d7a9b7c5bc85a56
Author: Greg Mann <[email protected]>
Date:   Fri Feb 23 16:41:46 2018 -0800

    Updated discard handling for Docker 'stop' and 'pull' commands.

    Review: https://reviews.apache.org/r/65787/
{code}

> Improve discard handling for 'Docker::stop' and 'Docker::pull'
> --------------------------------------------------------------
>
>                 Key: MESOS-8575
>                 URL: https://issues.apache.org/jira/browse/MESOS-8575
>             Project: Mesos
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Greg Mann
>            Assignee: Greg Mann
>            Priority: Major
>              Labels: mesosphere
>             Fix For: 1.6.0
>
>
> The functions in the Docker library which issue Docker CLI commands should be 
> updated so that when the {{Future}} they return is discarded, any 
> subprocesses which have been spawned will be cleaned up.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to