[ https://issues.apache.org/jira/browse/MESOS-8576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379603#comment-16379603 ]
Greg Mann commented on MESOS-8576: ---------------------------------- {code} commit a4805eff5dbef7146f34b239b834a688954991f9 Author: Greg Mann g...@mesosphere.io Date: Tue Feb 27 16:42:10 2018 -0800 Ensured that Docker containerizer returns a failed Future in one case. Because the Docker library did not immediately transition the Future returned by `inspect()` to DISCARDED, it was safe for the Docker containerizer to discard this Future before failing the Promise associated with the Future returned by `launch()`. However, the introduction of an `onDiscard` callback in `Docker::inspect()` makes this assumption invalid. This patch addresses this by failing the Promise before discarding the Future. Review: https://reviews.apache.org/r/65743/ {code} > Improve discard handling of 'Docker::inspect()' > ----------------------------------------------- > > Key: MESOS-8576 > URL: https://issues.apache.org/jira/browse/MESOS-8576 > Project: Mesos > Issue Type: Improvement > Components: containerization, docker > Affects Versions: 1.5.0 > Reporter: Greg Mann > Assignee: Greg Mann > Priority: Major > Labels: mesosphere > > In the call path of {{Docker::inspect()}}, each continuation currently checks > if {{promise->future().hasDiscard()}}, where the {{promise}} is associated > with the output of the {{docker inspect}} call. However, if the call to > {{docker inspect}} becomes hung indefinitely, then continuations are never > invoked, and a subsequent discard of the returned {{Future}} will have no > effect. We should add proper {{onDiscard}} handling to that {{Future}} so > that appropriate cleanup is performed in such cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)