[ 
https://issues.apache.org/jira/browse/MESOS-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387423#comment-16387423
 ] 

Qian Zhang commented on MESOS-8640:
-----------------------------------

RR: https://reviews.apache.org/r/65915/

> Validate `DockerInfo` exists when container's type is `DOCKER`
> --------------------------------------------------------------
>
>                 Key: MESOS-8640
>                 URL: https://issues.apache.org/jira/browse/MESOS-8640
>             Project: Mesos
>          Issue Type: Improvement
>          Components: containerization
>            Reporter: Qian Zhang
>            Assignee: Qian Zhang
>            Priority: Major
>
> Currently when framework launches a task whose ContainerInfo's type is DOCKER 
> (i.e., Docker containerizer will be used to launch the container), we do not 
> validate if the `DockerInfo` exists in the ContainerInfo, so such task will 
> be sent from master to agent, and will eventually fail due to pulling image 
> with empty name.
> {code:java}
> Failed to launch container: Failed to run 'docker -H 
> unix:///var/run/docker.sock pull :latest': exited with status 1; 
> stderr='invalid reference format'
> {code}
> Actually we have a validation in [this 
> code|https://github.com/apache/mesos/blob/1.5.0/src/docker/docker.cpp#L605:L607],
>  but it is too late (i.e., when Docker executor tries to create the Docker 
> container), we should do the validation much earlier, e.g., in master.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to