[ 
https://issues.apache.org/jira/browse/MESOS-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398052#comment-16398052
 ] 

Qian Zhang commented on MESOS-7656:
-----------------------------------

commit 5b2261409e2b391d9182c5579e1df481c7f0779f
Author: Qian Zhang 
Date: Mon Jul 10 15:21:55 2017 +0800

Added protobuf map support to stout JSON<->protobuf conversion.
 
 Map is a feature of proto2 syntax, but it can only be compiled
 with 3.0.0+ protobuf compiler, see the following discussion for
 details:
 
 https://groups.google.com/forum/#!topic/protobuf/p4WxcplrlA4
 
 We have already upgraded the compiler from 2.6.1 to 3.3.0 in
 MESOS-7228. This patch adds map support in the json <-> protobuf
 conversion in stout.
 
 Review: [https://reviews.apache.org/r/59987/]

 

commit 98358c01af6ebb1c9f2fcea9dca96389f3a6e1ed
Author: Qian Zhang 
Date: Mon Jul 10 15:22:20 2017 +0800

Added a new protobuf message `MapMessage` for protobuf tests.
 
 Review: [https://reviews.apache.org/r/59988/]

 

commit 67cd0de367a8da2f51fec1f1a7e808516794606e
Author: Qian Zhang 
Date: Mon Jul 10 15:22:29 2017 +0800

Added a test `ProtobufTest.JsonifyMap`.
 
 Review: [https://reviews.apache.org/r/59989/]

 

> Update the JSON <=> protobuf message conversion for map support
> ---------------------------------------------------------------
>
>                 Key: MESOS-7656
>                 URL: https://issues.apache.org/jira/browse/MESOS-7656
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Qian Zhang
>            Assignee: Qian Zhang
>            Priority: Major
>             Fix For: 1.6.0
>
>
> [Map|https://developers.google.com/protocol-buffers/docs/proto#maps] is a 
> feature starting from proto2 syntax, but it can only be compiled with proto3 
> compiler, see the following discussion for details:
> https://groups.google.com/forum/#\!topic/protobuf/p4WxcplrlA4
> We have already upgraded the protobuf compiler from 2.6.1 to 3.3.0 in 
> [MESOS-7228|https://issues.apache.org/jira/browse/MESOS-7228], however, to 
> use protobuf map in Mesos code, we also need to add the protobuf map support 
> to the code in Mesos for converting protobuf message to JSON object and 
> parsing JSON object as protobuf message, that is what we plan to handle in 
> this ticket.
> With map support added, the following field in the protobuf message can be 
> replaced by the native protobuf map field, and we do not have to manually 
> parse it anymore.
> https://github.com/apache/mesos/blob/1.3.0/include/mesos/docker/v1.proto#L68



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to