Chun-Hung Hsiao created MESOS-8715:
--------------------------------------
Summary: Consider removing conditional inclusion in the public
header `csi/spec.hpp`.
Key: MESOS-8715
URL: https://issues.apache.org/jira/browse/MESOS-8715
Project: Mesos
Issue Type: Improvement
Components: storage
Reporter: Chun-Hung Hsiao
Currently we conditionally include {{csi.grpc.pb.h}} in {{csi/spec.hpp}} based
on the configuration config {{ENABLE_GRPC}}, which is not ideal since this
makes the public header depends on an some-what internal configuration flag. We
could consider one of the following approaches to remove such dependency:
1. Generate a blank {{csi.grpc.pb.h}} when gRPC is not enabled.
2. Split {{csi/spec.hpp}} into {{csi/messages.hpp}} and {{csi/services.hpp}},
and do the conditional inclusion of {{csi/services.hpp}} in the implementation
files.
3. Only include {{csi.pb.h}} in {{csi/spec.hpp}} since Mesos is only publicly
dependent on the proto messages. Have a {{src/csi/services.hpp}} to include
{{csi.grpc.pb.h}}.
4. Remove this wrapper header file and directly include {{csi.pb.h}} and
{{csi.grpc.pb.h}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
