[
https://issues.apache.org/jira/browse/MESOS-8545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405510#comment-16405510
]
Alexander Rukletsov edited comment on MESOS-8545 at 3/26/18 1:04 PM:
---------------------------------------------------------------------
{noformat}
commit 02ebf9986ab5ce883a71df72e9e3392a3e37e40e
Author: Andrei Budnik <[email protected]>
AuthorDate: Mon Mar 19 22:48:31 2018 +0100
Commit: Alexander Rukletsov <[email protected]>
CommitDate: Mon Mar 19 22:48:31 2018 +0100
Fixed disconnection for ATTACH_CONTAINER_INPUT call in IOSwitchboard.
Previously, an http response for the `ATTACH_CONTAINER_INPUT` call
could be lost due to immediate termination of the IOSwitchboard
process after the termination of the IOSwitchboard actor. Since the
IOSwitchboard process didn't wait for completion of sending all
responses back to the agent, the agent received disconnection error.
To fix the issue, this patch adds explicit finalization of libprocess
before returning from the IOSwitchboard's main function.
Review: https://reviews.apache.org/r/66147/
{noformat}
{noformat}
commit 1ed3eae3ca09c8fdeac349d78e568d2a91be306b
Author: Andrei Budnik <[email protected]>
AuthorDate: Mon Mar 26 15:03:30 2018 +0200
Commit: Alexander Rukletsov <[email protected]>
CommitDate: Mon Mar 26 15:03:30 2018 +0200
Ensured correct termination order in IOSwitchboard's main function.
This patch terminates `IOSwitchboardServer` actor before calling
`process::finalize()`. This patch is an addition to commit 02ebf9986a.
Review: https://reviews.apache.org/r/66278/
{noformat}
was (Author: alexr):
{noformat}
commit 02ebf9986ab5ce883a71df72e9e3392a3e37e40e
Author: Andrei Budnik <[email protected]>
AuthorDate: Mon Mar 19 22:48:31 2018 +0100
Commit: Alexander Rukletsov <[email protected]>
CommitDate: Mon Mar 19 22:48:31 2018 +0100
Fixed disconnection for ATTACH_CONTAINER_INPUT call in IOSwitchboard.
Previously, an http response for the `ATTACH_CONTAINER_INPUT` call
could be lost due to immediate termination of the IOSwitchboard
process after the termination of the IOSwitchboard actor. Since the
IOSwitchboard process didn't wait for completion of sending all
responses back to the agent, the agent received disconnection error.
To fix the issue, this patch adds explicit finalization of libprocess
before returning from the IOSwitchboard's main function.
Review: https://reviews.apache.org/r/66147/
{noformat}
> AgentAPIStreamingTest.AttachInputToNestedContainerSession is flaky.
> -------------------------------------------------------------------
>
> Key: MESOS-8545
> URL: https://issues.apache.org/jira/browse/MESOS-8545
> Project: Mesos
> Issue Type: Bug
> Components: agent
> Affects Versions: 1.5.0
> Reporter: Andrei Budnik
> Assignee: Andrei Budnik
> Priority: Major
> Labels: Mesosphere, flaky-test
> Fix For: 1.6.0
>
> Attachments:
> AgentAPIStreamingTest.AttachInputToNestedContainerSession-badrun.txt,
> AgentAPIStreamingTest.AttachInputToNestedContainerSession-badrun2.txt
>
>
> {code:java}
> I0205 17:11:01.091872 4898 http_proxy.cpp:132] Returning '500 Internal Server
> Error' for '/slave(974)/api/v1' (Disconnected)
> /home/centos/workspace/mesos/Mesos_CI-build/FLAG/CMake/label/mesos-ec2-centos-7/mesos/src/tests/api_tests.cpp:6596:
> Failure
> Value of: (response).get().status
> Actual: "500 Internal Server Error"
> Expected: http::OK().status
> Which is: "200 OK"
> Body: "Disconnected"
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
