[
https://issues.apache.org/jira/browse/MESOS-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420828#comment-16420828
]
Chun-Hung Hsiao edited comment on MESOS-8749 at 3/30/18 6:49 PM:
-----------------------------------------------------------------
{noformat}
commit 62de7bbfe90ba373075509dfddc23b23239f5cc9
Author: Chun-Hung Hsiao <[email protected]>
Date: Thu Mar 29 16:51:19 2018 -0700
Temporarily disabled CSI proto compilation in CMake.
The `major` and `minor` macros defined on some systems conflict with
field names in the CSI v0.1.0 spec proto. Temporarily disable it in
CMake until CSI is bumped to 0.2.
Review: https://reviews.apache.org/r/66371
{noformat}
was (Author: chhsia0):
{noformat}
commit 62de7bbfe90ba373075509dfddc23b23239f5cc9 (HEAD -> disable-csi,
upstream/master)
Author: Chun-Hung Hsiao <[email protected]>
Date: Thu Mar 29 16:51:19 2018 -0700
Temporarily disabled CSI proto compilation in CMake.
The `major` and `minor` macros defined on some systems conflict with
field names in the CSI v0.1.0 spec proto. Temporarily disable it in
CMake until CSI is bumped to 0.2.
Review: https://reviews.apache.org/r/66371
{noformat}
> CSI proto is always included in the build when using CMake
> ----------------------------------------------------------
>
> Key: MESOS-8749
> URL: https://issues.apache.org/jira/browse/MESOS-8749
> Project: Mesos
> Issue Type: Task
> Environment: FreeBSD 11.1-RELEASE
> Reporter: David Forsythe
> Assignee: Chun-Hung Hsiao
> Priority: Minor
> Fix For: 1.6.0
>
>
> cmake ../mesos
> make LDFLAGS='-lexecinfo -lm'
> {code:java}
> ...
> [ 36%] Building CXX object
> src/CMakeFiles/mesos-protobufs.dir/__/include/csi/csi.pb.cc.o
> cd /mesos-build/src && /usr/bin/c++ -DLIBDIR=\"/usr/local/libmesos\"
> -DPKGDATADIR=\"/usr/local/share/mesos\"
> -DPKGLIBEXECDIR=\"/usr/local/libexec/mesos\" -DVERSION=\"1.6.0\"
> -Dmesos_protobufs_EXPORTS -I/mesos-build/include -I/mesos-build/include/mesos
> -I/mesos-build/src -I/mesos/src -I/mesos-build/include/csi -isystem
> /mesos-build/3rdparty/protobuf-3.5.0/src/protobuf-3.5.0/src -fPIC -Wall
> -Wsign-compare -Wformat-security -fstack-protector-strong -std=c++11 -o
> CMakeFiles/mesos-protobufs.dir/__/include/csi/csi.pb.cc.o -c
> /mesos-build/include/csi/csi.pb.cc
> In file included from /mesos-build/include/csi/csi.pb.cc:4:
> /mesos-build/include/csi/csi.pb.h:763:30: error: expected member name or ';'
> after declaration specifiers
> ::google::protobuf::uint32 major() const;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
> /usr/include/sys/types.h:372:20: note: expanded from macro 'major'
> #define major(x) ((int)(((u_int)(x) >> 8)&0xff)) /* major number */
> ^
> In file included from /mesos-build/include/csi/csi.pb.cc:4:
> /mesos-build/include/csi/csi.pb.h:763:30: error: expected ')'
> /usr/include/sys/types.h:372:20: note: expanded from macro 'major'
> #define major(x) ((int)(((u_int)(x) >> 8)&0xff)) /* major number */
> ^
> /mesos-build/include/csi/csi.pb.h:763:30: note: to match this '('
> /usr/include/sys/types.h:372:19: note: expanded from macro 'major'
> #define major(x) ((int)(((u_int)(x) >> 8)&0xff)) /* major number */
> ^
> In file included from /mesos-build/include/csi/csi.pb.cc:4:
> /mesos-build/include/csi/csi.pb.h:763:30: error: expected ')'
> ::google::protobuf::uint32 major() const;
> ^
> /usr/include/sys/types.h:372:37: note: expanded from macro 'major'
> #define major(x) ((int)(((u_int)(x) >> 8)&0xff)) /* major number */
> ^
> /mesos-build/include/csi/csi.pb.h:763:30: note: to match this '('
> /usr/include/sys/types.h:372:25: note: expanded from macro 'major'
> #define major(x) ((int)(((u_int)(x) >> 8)&0xff)) /* major number */
> ^
> In file included from /mesos-build/include/csi/csi.pb.cc:4:
> /mesos-build/include/csi/csi.pb.h:763:30: error: C++ requires a type
> specifier for all declarations
> ::google::protobuf::uint32 major() const;
> ^
> /usr/include/sys/types.h:372:27: note: expanded from macro 'major'
> #define major(x) ((int)(((u_int)(x) >> 8)&0xff)) /* major number */
> ^
> In file included from /mesos-build/include/csi/csi.pb.cc:4:
> /mesos-build/include/csi/csi.pb.h:763:30: error: function cannot return
> function type 'int (())'
> /usr/include/sys/types.h:372:26: note: expanded from macro 'major'
> #define major(x) ((int)(((u_int)(x) >> 8)&0xff)) /* major number */
> ^
> In file included from /mesos-build/include/csi/csi.pb.cc:4:
> /mesos-build/include/csi/csi.pb.h:763:30: error: expected ')'
> /usr/include/sys/types.h:372:42: note: expanded from macro 'major'
> #define major(x) ((int)(((u_int)(x) >> 8)&0xff)) /* major number */
> ^
> /mesos-build/include/csi/csi.pb.h:763:30: note: to match this '('
> /usr/include/sys/types.h:372:24: note: expanded from macro 'major'
> #define major(x) ((int)(((u_int)(x) >> 8)&0xff)) /* major number */
> ^
> In file included from /mesos-build/include/csi/csi.pb.cc:4:
> /mesos-build/include/csi/csi.pb.h:769:30: error: expected member name or ';'
> after declaration specifiers
> ::google::protobuf::uint32 minor() const;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
> /usr/include/sys/types.h:373:20: note: expanded from macro 'minor'
> #define minor(x) ((int)((x)&0xffff00ff)) /* minor number */
> ^
> In file included from /mesos-build/include/csi/csi.pb.cc:4:
> /mesos-build/include/csi/csi.pb.h:769:30: error: expected ')'
> /usr/include/sys/types.h:373:20: note: expanded from macro 'minor'
> #define minor(x) ((int)((x)&0xffff00ff)) /* minor number */
> ^
> /mesos-build/include/csi/csi.pb.h:769:30: note: to match this '('
> /usr/include/sys/types.h:373:19: note: expanded from macro 'minor'
> #define minor(x) ((int)((x)&0xffff00ff)) /* minor number */
> ^
> In file included from /mesos-build/include/csi/csi.pb.cc:4:
> /mesos-build/include/csi/csi.pb.h:769:30: error: C++ requires a type
> specifier for all declarations
> ::google::protobuf::uint32 minor() const;
> ^
> /usr/include/sys/types.h:373:27: note: expanded from macro 'minor'
> #define minor(x) ((int)((x)&0xffff00ff)) /* minor number */
> ^
> In file included from /mesos-build/include/csi/csi.pb.cc:4:
> /mesos-build/include/csi/csi.pb.h:769:30: error: non-member function cannot
> have '&' qualifier
> /usr/include/sys/types.h:373:28: note: expanded from macro 'minor'
> #define minor(x) ((int)((x)&0xffff00ff)) /* minor number */
> ^
> In file included from /mesos-build/include/csi/csi.pb.cc:4:
> /mesos-build/include/csi/csi.pb.h:769:30: error: expected ')'
> /usr/include/sys/types.h:373:29: note: expanded from macro 'minor'
> #define minor(x) ((int)((x)&0xffff00ff)) /* minor number */
> ^
> /mesos-build/include/csi/csi.pb.h:769:30: note: to match this '('
> /usr/include/sys/types.h:373:24: note: expanded from macro 'minor'
> #define minor(x) ((int)((x)&0xffff00ff)) /* minor number */
> ^
> In file included from /mesos-build/include/csi/csi.pb.cc:4:
> /mesos-build/include/csi/csi.pb.h:6028:44: error: expected unqualified-id
> inline ::google::protobuf::uint32 Version::major() const {
> ^
> /mesos-build/include/csi/csi.pb.h:6042:44: error: expected unqualified-id
> inline ::google::protobuf::uint32 Version::minor() const {
> ^
> /mesos-build/include/csi/csi.pb.cc:3045:13: error: expected unqualified-id
> if (this->major() != 0) {
> ^
> /usr/include/sys/types.h:372:18: note: expanded from macro 'major'
> #define major(x) ((int)(((u_int)(x) >> 8)&0xff)) /* major number */
> ^
> /mesos-build/include/csi/csi.pb.cc:3045:13: error: expected expression
> /usr/include/sys/types.h:372:35: note: expanded from macro 'major'
> #define major(x) ((int)(((u_int)(x) >> 8)&0xff)) /* major number */
> ^
> /mesos-build/include/csi/csi.pb.cc:3046:72: error: expected unqualified-id
> ::google::protobuf::internal::WireFormatLite::WriteUInt32(1,
> this->major(), output);
> ^
> /usr/include/sys/types.h:372:18: note: expanded from macro 'major'
> #define major(x) ((int)(((u_int)(x) >> 8)&0xff)) /* major number */
> ^
> /mesos-build/include/csi/csi.pb.cc:3046:72: error: expected expression
> /usr/include/sys/types.h:372:35: note: expanded from macro 'major'
> #define major(x) ((int)(((u_int)(x) >> 8)&0xff)) /* major number */
> ^
> /mesos-build/include/csi/csi.pb.cc:3050:13: error: expected unqualified-id
> if (this->minor() != 0) {
> ^
> /usr/include/sys/types.h:373:18: note: expanded from macro 'minor'
> #define minor(x) ((int)((x)&0xffff00ff)) /* minor number */
> ^
> /mesos-build/include/csi/csi.pb.cc:3050:13: error: expected expression
> /usr/include/sys/types.h:373:27: note: expanded from macro 'minor'
> #define minor(x) ((int)((x)&0xffff00ff)) /* minor number */
> ^
> fatal error: too many errors emitted, stopping now [-ferror-limit=]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
