[
https://issues.apache.org/jira/browse/MESOS-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425061#comment-16425061
]
Andrew Schwartzmeyer commented on MESOS-8676:
---------------------------------------------
We should probably add another issue for adding overlapped-ness to these (and
perhaps split this into two issues, read and write).
> Fix os::read and os::write to work with files in overlapped mode
> ----------------------------------------------------------------
>
> Key: MESOS-8676
> URL: https://issues.apache.org/jira/browse/MESOS-8676
> Project: Mesos
> Issue Type: Task
> Reporter: Andrew Schwartzmeyer
> Assignee: Andrew Schwartzmeyer
> Priority: Major
> Labels: stout, windows
>
> When fixing {{os::open}} to open real Windows {{HANDLE}} s to files in a
> default overlapped mode, we'll need to fix {{os::read}} and {{os::write}} to
> work with these. Since these functions are inherently synchronous, we'll just
> use overlapped I/O but wait for completion, making the action synchronous.
> Caveat: when files on Windows are opened in overlapped mode, they no longer
> retain state about the offset. Because these functions currently use the CRT
> APIs {{_read}} and {{_write}}, they act like POSIX file descriptors which are
> advanced by N bytes per read and write. We can mimic this behavior by saving
> the offset state in the {{WindowsFD}} abstraction.
> Also fix use of {{WSAGetLastError}} since not all reads/writes are on sockets.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
