Andrew Schwartzmeyer created MESOS-8764:
-------------------------------------------

             Summary: Delete WindowsSocketError and reconcile with SocketError 
and WindowsError
                 Key: MESOS-8764
                 URL: https://issues.apache.org/jira/browse/MESOS-8764
             Project: Mesos
          Issue Type: Task
            Reporter: Andrew Schwartzmeyer


It turns out that there is no actual difference between {{WSAGetLastError}} and 
{{GetLastError}}, the [former is an alias for the 
latter|https://stackoverflow.com/questions/15586224/is-wsagetlasterror-just-an-alias-for-getlasterror]
 (also see [here|https://paginas.fe.up.pt/~jmcruz/etc/sockets/winsock22.pdf]. 
As such, there is no difference between {{WindowsError}} and 
{{WindowsSocketError}}.

So we should delete the notion of a separate {{WindowsSocketError}} class, and 
reconcile {{SocketError}}. Then {{WindowsErrorBase}} can disappear, leaving us 
with just {{WindowsError}}.

Moreover, with the use of CRT APIs pretty much gone, we probably no longer need 
{{ErrnoError}} defined in the Windows code either, so we could find a way to 
make {{WindowsError}} and {{ErrnoError}} the transparent platform-defaults 
(though is not necessarily a good idea).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to