[ 
https://issues.apache.org/jira/browse/MESOS-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435505#comment-16435505
 ] 

Kevin Klues commented on MESOS-8240:
------------------------------------

{noformat}
commit 2f7f03f249a724d61265dabfadb5bb83eb2008e8
Author: Armand Grillet <agril...@mesosphere.io>
Date:   Thu Apr 12 14:37:10 2018 +0200

    Improved documentation regarding the new CLI setup.
    
    Explains how to create the necessary virtual environment from
    anywhere and how to set up autocompletion in such case.
    
    Also removes an unnecessary activation of the virtual environment
    in `mesos` and `mesos-cli-tests`.
    
    Review: https://reviews.apache.org/r/65585/
{noformat}
{noformat}
commit b6ea804322c85eae066c6b52239063b1169f54a3 (HEAD)
Author: Armand Grillet <agril...@mesosphere.io>
Date:   Thu Apr 12 14:43:54 2018 +0200

    Removed 'source activate' from new CLI wrapper scripts.
    
    Having these command in these scripts was only necessary if you wanted
    to run them from outside the virtual environment they were meant to run
    in. Since we will soon be allowing people to create this virtual
    environment anywhere on their filesystem, it doesn't make sense to
    assume they have done it in the 'src/python/cli_new' directory anymore.
    
    Since we can't assume that, we will just have to mandate that the
    virtualenv is actually set up before invoking these scripts.
{noformat}

> Add an option to build the new CLI and run unit tests.
> ------------------------------------------------------
>
>                 Key: MESOS-8240
>                 URL: https://issues.apache.org/jira/browse/MESOS-8240
>             Project: Mesos
>          Issue Type: Improvement
>          Components: cli
>            Reporter: Armand Grillet
>            Assignee: Armand Grillet
>            Priority: Major
>
> An update of the discarded [https://reviews.apache.org/r/52543/]
> Also needs to be available for CMake.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to