[
https://issues.apache.org/jira/browse/MESOS-8717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436312#comment-16436312
]
Chun-Hung Hsiao edited comment on MESOS-8717 at 4/13/18 1:43 AM:
-----------------------------------------------------------------
{noformat}
commit ea5d10873667815a026ec76af5ae94968f206084
Author: Chun-Hung Hsiao <chhs...@apache.org>
Date: Thu Apr 12 12:07:14 2018 -0700
Updated CSI helpers for v0.2.
This patch adds new helper classes for CSI plugin and node capabilities,
removed helpers for the removed csi.Version proto message, and makes
the VolumeState proto message uses csi::v0::VolumeCapability.
NOTE: This is not future-proof if there is a breaking change in
VolumeCapability, we might need to change VolumeState to support
multiple CSI versions in the future.
Review: https://reviews.apache.org/r/66408/
{noformat}
{noformat}
commit 6dfd2594123b6218254081bf230c3fba11c65027
Author: Chun-Hung Hsiao <chhs...@apache.org>
Date: Thu Apr 12 12:07:17 2018 -0700
Used `csi::v0::VolumeCapability` in disk profile adaptors.
To adapt the change in CSI package names (from `csi` to `csi.v0`), we
now use `csi::v0::VolumeCapability` in the disk profile adaptor module
interface.
NOTE: This is not future-proof if there is a breaking change in
`VolumeCapability`, we might need to change the module interface to
support multiple CSI versions in the future.
Review: https://reviews.apache.org/r/66409/
{noformat}
{noformat}
commit aeffcd7d9a1f9c97e5e347063ceab71c43c00e2d
Author: Chun-Hung Hsiao <chhs...@apache.org>
Date: Thu Apr 12 12:07:19 2018 -0700
Adapted storage local resource provider to use CSI v0.2.
This patch contains necessary changes for the storage local resource
provider to use CSI v0.2. Support for the `STAGE_UNSTAGE_VOLUME` CSI
node service capability is not implemented in this patch yet.
Review: https://reviews.apache.org/r/66410/
{noformat}
{noformat}
commit f852ffaccece40ddd2ba1ac1b29a117687bf6917
Author: Chun-Hung Hsiao <chhs...@apache.org>
Date: Thu Apr 12 12:34:02 2018 -0700
Made the test CSI plugin compatible to CSI v0.2.
This patch contains necessary changes for the test CSI plugin to support
CSI v0.2. The `STAGE_UNSTAGE_VOLUME` node service capability is not
implemented in this patch yet.
Review: https://reviews.apache.org/r/66411/
{noformat}
{noformat}
commit 554503985288dde4cd016c424b17cf3aedb1e4b0
Author: Chun-Hung Hsiao chhs...@apache.org
Date: Thu Apr 12 18:41:42 2018 -0700
Handled failed publish and unpublish CSI calls properly.
Previously, when a `ControllerPublishVolume` or a `NodePublishVolume`
fails, SLRP assumes the volume states remain unchanged, which are not
suggested by the CSI spec. This patch handles such failures properly.
Review: https://reviews.apache.org/r/66418/
{noformat}
was (Author: chhsia0):
{noformat}
commit ea5d10873667815a026ec76af5ae94968f206084
Author: Chun-Hung Hsiao <chhs...@apache.org>
Date: Thu Apr 12 12:07:14 2018 -0700
Updated CSI helpers for v0.2.
This patch adds new helper classes for CSI plugin and node capabilities,
removed helpers for the removed csi.Version proto message, and makes
the VolumeState proto message uses csi::v0::VolumeCapability.
NOTE: This is not future-proof if there is a breaking change in
VolumeCapability, we might need to change VolumeState to support
multiple CSI versions in the future.
Review: https://reviews.apache.org/r/66408/
{noformat}
{noformat}
commit 6dfd2594123b6218254081bf230c3fba11c65027
Author: Chun-Hung Hsiao <chhs...@apache.org>
Date: Thu Apr 12 12:07:17 2018 -0700
Used `csi::v0::VolumeCapability` in disk profile adaptors.
To adapt the change in CSI package names (from `csi` to `csi.v0`), we
now use `csi::v0::VolumeCapability` in the disk profile adaptor module
interface.
NOTE: This is not future-proof if there is a breaking change in
`VolumeCapability`, we might need to change the module interface to
support multiple CSI versions in the future.
Review: https://reviews.apache.org/r/66409/
{noformat}
{noformat}
commit aeffcd7d9a1f9c97e5e347063ceab71c43c00e2d
Author: Chun-Hung Hsiao <chhs...@apache.org>
Date: Thu Apr 12 12:07:19 2018 -0700
Adapted storage local resource provider to use CSI v0.2.
This patch contains necessary changes for the storage local resource
provider to use CSI v0.2. Support for the `STAGE_UNSTAGE_VOLUME` CSI
node service capability is not implemented in this patch yet.
Review: https://reviews.apache.org/r/66410/
{noformat}
{noformat}
commit f852ffaccece40ddd2ba1ac1b29a117687bf6917 (HEAD -> csi-0.2,
upstream/master)
Author: Chun-Hung Hsiao <chhs...@apache.org>
Date: Thu Apr 12 12:34:02 2018 -0700
Made the test CSI plugin compatible to CSI v0.2.
This patch contains necessary changes for the test CSI plugin to support
CSI v0.2. The `STAGE_UNSTAGE_VOLUME` node service capability is not
implemented in this patch yet.
Review: https://reviews.apache.org/r/66411/
{noformat}
> Support CSI v0.2 in SLRP.
> -------------------------
>
> Key: MESOS-8717
> URL: https://issues.apache.org/jira/browse/MESOS-8717
> Project: Mesos
> Issue Type: Task
> Components: storage
> Reporter: Chun-Hung Hsiao
> Assignee: Chun-Hung Hsiao
> Priority: Blocker
> Labels: mesosphere, storage
> Fix For: 1.6.0
>
>
> SLRP needs to be modified to talk to plugins using CSI v0.2.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
