[
https://issues.apache.org/jira/browse/MESOS-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449297#comment-16449297
]
Andrew Schwartzmeyer edited comment on MESOS-8275 at 4/24/18 5:16 AM:
----------------------------------------------------------------------
I have {{mtime}} working and delete the others, but there's still these to look
at:
{noformat}
src/tests/files_tests.cpp
340: ASSERT_EQ(0, ::stat(path::join("1", "2").c_str(), &s));
343: ASSERT_EQ(0, ::stat(path::join("1", "3").c_str(), &s));
346: ASSERT_EQ(0, ::stat(path::join("1", "three").c_str(), &s));
349: ASSERT_EQ(0, ::stat(path::join("1", "two").c_str(), &s));
src/tests/container_logger_tests.cpp
770: ASSERT_GE(::stat(stdoutPath.c_str(), &stdoutStat), 0);
src/slave/containerizer/docker.cpp
505: if (::stat(directory.c_str(), &s) < 0) {
src/tests/containerizer/mesos_containerizer_tests.cpp
696: EXPECT_EQ(0, ::stat(stdoutPath.c_str(), &s));
701: EXPECT_EQ(0, ::stat(stderrPath.c_str(), &s));
src/tests/containerizer/docker_containerizer_tests.cpp
4221: ASSERT_GE(::stat(stdoutPath.c_str(), &stdoutStat), 0);
3rdparty/stout/include/stout/os/permissions.hpp
64: if (::stat(path.c_str(), &status) < 0) {
{noformat}
I think we can mostly ignore those in tests (and I already removed Linux/POSIX
results). For {{permissions.hpp}}, it seems reasonably to me to just emit a
warning pending MESOS-3176, which just leaves the use in {{docker.cpp}}...
was (Author: andschwa):
I have {{mtime}} working and delete the others, but there's still these to look
at:
{noformat}
src/tests/files_tests.cpp
340: ASSERT_EQ(0, ::stat(path::join("1", "2").c_str(), &s));
343: ASSERT_EQ(0, ::stat(path::join("1", "3").c_str(), &s));
346: ASSERT_EQ(0, ::stat(path::join("1", "three").c_str(), &s));
349: ASSERT_EQ(0, ::stat(path::join("1", "two").c_str(), &s));
src/tests/container_logger_tests.cpp
770: ASSERT_GE(::stat(stdoutPath.c_str(), &stdoutStat), 0);
src/slave/containerizer/docker.cpp
505: if (::stat(directory.c_str(), &s) < 0) {
src/tests/containerizer/mesos_containerizer_tests.cpp
696: EXPECT_EQ(0, ::stat(stdoutPath.c_str(), &s));
701: EXPECT_EQ(0, ::stat(stderrPath.c_str(), &s));
src/tests/containerizer/docker_containerizer_tests.cpp
4221: ASSERT_GE(::stat(stdoutPath.c_str(), &stdoutStat), 0);
3rdparty/stout/include/stout/os/permissions.hpp
64: if (::stat(path.c_str(), &status) < 0) {
{noformat}
I think we can mostly ignore those in test (and I already removed Linux/POSIX
results). For {{permissions.hpp}}, it seems reasonably to me to just emit a
warning pending MESOS-3176, which just leaves the use in {{docker.cpp}}...
> Remove use of ::_stat on Windows
> --------------------------------
>
> Key: MESOS-8275
> URL: https://issues.apache.org/jira/browse/MESOS-8275
> Project: Mesos
> Issue Type: Task
> Environment: Windows
> Reporter: Andrew Schwartzmeyer
> Assignee: Andrew Schwartzmeyer
> Priority: Major
> Labels: stout, windows
>
> The Windows stat.hpp header has some remaining uses of non-long-path-aware
> CRT APIs, specifically {{::_stat}}. This has been punted so far as not yet a
> problem, but eventually should be fixed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
